Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Audio messages new design #WPB-11723 #3718

Open
wants to merge 22 commits into
base: develop
Choose a base branch
from

Conversation

borichellow
Copy link
Contributor

@borichellow borichellow commented Dec 9, 2024

StoryWPB-11723 [Android] Playback improvement - 1 - Scroll / Duration / Speed


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

New design for Audio messages. Main changes:

  • "wave mask" of audio instead of line
  • option to change audio speed

Attachments (Optional)

Screenshot 2024-12-11 at 15 01 58 Screenshot 2024-12-17 at 16 56 25

waiting for kalium PR be merged

@borichellow borichellow self-assigned this Dec 9, 2024
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Dec 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 53.80117% with 79 lines in your changes missing coverage. Please review.

Project coverage is 45.81%. Comparing base (8847c15) to head (99ff18f).

Files with missing lines Patch % Lines
...android/media/audiomessage/AudioWavesMaskHelper.kt 3.84% 25 Missing ⚠️
...dia/audiomessage/ConversationAudioMessagePlayer.kt 62.74% 18 Missing and 1 partial ⚠️
.../com/wire/android/media/audiomessage/AudioState.kt 54.54% 9 Missing and 1 partial ⚠️
...tions/model/messagetypes/audio/AudioMessageType.kt 0.00% 8 Missing ⚠️
...oid/media/audiomessage/RecordAudioMessagePlayer.kt 0.00% 5 Missing ⚠️
...d/ui/home/conversations/media/FileAssetsContent.kt 0.00% 3 Missing ⚠️
...rsations/messages/ConversationMessagesViewModel.kt 91.66% 2 Missing and 1 partial ⚠️
...essagecomposer/recordaudio/RecordAudioViewModel.kt 50.00% 1 Missing and 2 partials ⚠️
...conversations/messages/item/MessageClickActions.kt 0.00% 2 Missing ⚠️
...kotlin/com/wire/android/util/DateAndTimeParsers.kt 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3718      +/-   ##
===========================================
+ Coverage    45.70%   45.81%   +0.11%     
===========================================
  Files          477      478       +1     
  Lines        16223    16343     +120     
  Branches      2746     2763      +17     
===========================================
+ Hits          7415     7488      +73     
- Misses        8038     8082      +44     
- Partials       770      773       +3     
Files with missing lines Coverage Δ
...rsations/messages/ConversationMessagesViewState.kt 100.00% <100.00%> (ø)
.../conversations/messages/item/RegularMessageItem.kt 0.00% <ø> (ø)
...kotlin/com/wire/android/util/DateAndTimeParsers.kt 75.51% <66.66%> (-0.58%) ⬇️
...conversations/messages/item/MessageClickActions.kt 0.00% <0.00%> (ø)
...d/ui/home/conversations/media/FileAssetsContent.kt 0.00% <0.00%> (ø)
...rsations/messages/ConversationMessagesViewModel.kt 70.17% <91.66%> (+4.18%) ⬆️
...essagecomposer/recordaudio/RecordAudioViewModel.kt 64.58% <50.00%> (-0.13%) ⬇️
...oid/media/audiomessage/RecordAudioMessagePlayer.kt 1.29% <0.00%> (-0.08%) ⬇️
...tions/model/messagetypes/audio/AudioMessageType.kt 0.00% <0.00%> (ø)
.../com/wire/android/media/audiomessage/AudioState.kt 58.92% <54.54%> (-3.24%) ⬇️
... and 2 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8847c15...99ff18f. Read the comment docs.

@borichellow borichellow added the WIP Work In Progress label Dec 10, 2024
Copy link
Contributor

Built wire-android-staging-compat-pr-3718.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3718.apk is available for download

@borichellow borichellow removed the WIP Work In Progress label Dec 12, 2024
@borichellow borichellow requested review from saleniuk, Garzas and m-zagorski and removed request for saleniuk and Garzas December 12, 2024 09:51
Copy link
Contributor

@saleniuk saleniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

Copy link

Ups 🫰🟨

This PR is too big. Please try to break it up into smaller PRs.

Copy link
Contributor

Built wire-android-staging-compat-pr-3718.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3718.apk is available for download

Copy link
Contributor

Built wire-android-staging-compat-pr-3718.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3718.apk is available for download

Copy link
Contributor

@yamilmedina yamilmedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic 👏 just one question 🤔 do we need to add obfuscation proguard/r8 rules for amplituda ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants