-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Audio messages new design #WPB-11723 #3718
base: develop
Are you sure you want to change the base?
Conversation
Built wire-android-staging-compat-pr-3718.apk is available for download |
Built wire-android-dev-debug-pr-3718.apk is available for download |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
app/src/main/kotlin/com/wire/android/media/audiomessage/AudioWavesMaskHelper.kt
Outdated
Show resolved
Hide resolved
Ups 🫰🟨This PR is too big. Please try to break it up into smaller PRs. |
Built wire-android-staging-compat-pr-3718.apk is available for download |
Built wire-android-dev-debug-pr-3718.apk is available for download |
Quality Gate passedIssues Measures |
Built wire-android-staging-compat-pr-3718.apk is available for download |
Built wire-android-dev-debug-pr-3718.apk is available for download |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fantastic 👏 just one question 🤔 do we need to add obfuscation proguard/r8 rules for amplituda ?
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
New design for Audio messages. Main changes:
Attachments (Optional)
waiting for kalium PR be merged