fix: show proper empty user search screens [WPB-6257] 🍒 (v4.7) #3604
+222
−170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echoes-hq
bot
added
the
echoes: features
|
Test Results945 tests 945 ✅ 10m 57s ⏱️ Results for commit 1986b83. |
|
APKs built during tests are available here. Scroll down to Artifacts! |
saleniuk
requested review from
a team,
typfel,
alexandreferris,
MohamadJaara,
Garzas and
ohassine
and removed request for
a team
yamilmedina
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was manually cherry-picked based on the following PR:
Original PR description:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
When we search for a user and don’t receive a result, then the correct search hint is not shown anymore.
Solutions
Use empty user search screens properly - when not searching show initial contacts list or empty screen with "learn more" button, when searching show results or "no results found" screen.
Removed unused fields from states, added/fixed loading state and previews for all possibilities.
Testing
How to Test
Search for a user which does not exist, or which you can not find due to search configurations.
Attachments (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.