-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: show proper empty user search screens [WPB-6257] 🍒 #3602
base: release/candidate
Are you sure you want to change the base?
fix: show proper empty user search screens [WPB-6257] 🍒 #3602
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #3602 +/- ##
=====================================================
+ Coverage 45.27% 45.29% +0.01%
=====================================================
Files 470 470
Lines 15802 15800 -2
Branches 2655 2655
=====================================================
+ Hits 7155 7157 +2
+ Misses 7879 7875 -4
Partials 768 768
Continue to review full report in Codecov by Sentry.
|
…into fix/proper-empty-user-search-screens-cherry-pick
Quality Gate passedIssues Measures |
Built wire-android-staging-compat-pr-3602.apk is available for download |
This PR was automatically cherry-picked based on the following PR:
Original PR description:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
When we search for a user and don’t receive a result, then the correct search hint is not shown anymore.
Solutions
Use empty user search screens properly - when not searching show initial contacts list or empty screen with "learn more" button, when searching show results or "no results found" screen.
Removed unused fields from states, added/fixed loading state and previews for all possibilities.
Testing
How to Test
Search for a user which does not exist, or which you can not find due to search configurations.
Attachments (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.