Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show proper empty user search screens [WPB-6257] 🍒 #3602

Open
wants to merge 4 commits into
base: release/candidate
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 7, 2024

This PR was automatically cherry-picked based on the following PR:

Original PR description:


BugWPB-6257 [Android] Search hint for no result is not shown anymore


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

When we search for a user and don’t receive a result, then the correct search hint is not shown anymore.

Solutions

Use empty user search screens properly - when not searching show initial contacts list or empty screen with "learn more" button, when searching show results or "no results found" screen.
Removed unused fields from states, added/fixed loading state and previews for all possibilities.

Testing

How to Test

Search for a user which does not exist, or which you can not find due to search configurations.

Attachments (Optional)

Before After

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions github-actions bot added echoes: features End-user visible changes intended to create customer value size/M labels Nov 7, 2024
@pull-request-size pull-request-size bot added size/L and removed size/M labels Nov 7, 2024
@pull-request-size pull-request-size bot added size/S and removed size/L labels Nov 7, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 45.29%. Comparing base (55863ae) to head (2f00375).

Files with missing lines Patch % Lines
...me/conversations/search/SearchServicesViewModel.kt 0.00% 5 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           release/candidate    #3602      +/-   ##
=====================================================
+ Coverage              45.27%   45.29%   +0.01%     
=====================================================
  Files                    470      470              
  Lines                  15802    15800       -2     
  Branches                2655     2655              
=====================================================
+ Hits                    7155     7157       +2     
+ Misses                  7879     7875       -4     
  Partials                 768      768              
Files with missing lines Coverage Δ
...i/home/conversations/search/SearchUserViewModel.kt 95.06% <100.00%> (+0.12%) ⬆️
...me/conversations/search/SearchServicesViewModel.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55863ae...2f00375. Read the comment docs.

Copy link

sonarcloud bot commented Nov 7, 2024

@saleniuk saleniuk requested review from a team, m-zagorski, yamilmedina, borichellow, vitorhugods and mathias-niboulies and removed request for a team November 7, 2024 14:30
Copy link
Contributor Author

github-actions bot commented Nov 7, 2024

Built wire-android-staging-compat-pr-3602.apk is available for download

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: features End-user visible changes intended to create customer value size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants