-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Report Metric of Personal User creating a team in Countly (WPB-11318) #3552
Conversation
# Conflicts: # app/src/main/kotlin/com/wire/android/ui/userprofile/self/SelfUserProfileScreen.kt # app/src/main/kotlin/com/wire/android/ui/userprofile/teammigration/PersonalToTeamMigrationNavGraph.kt # app/src/main/kotlin/com/wire/android/ui/userprofile/teammigration/TeamMigrationScreen.kt # app/src/main/kotlin/com/wire/android/ui/userprofile/teammigration/TeamMigrationViewModel.kt # app/src/main/kotlin/com/wire/android/ui/userprofile/teammigration/step1/TeamMigrationTeamPlanStepScreen.kt # app/src/main/kotlin/com/wire/android/ui/userprofile/teammigration/step2/TeamMigrationTeamNameStepScreen.kt # app/src/main/kotlin/com/wire/android/ui/userprofile/teammigration/step3/TeamMigrationConfirmationStepScreen.kt # app/src/main/kotlin/com/wire/android/ui/userprofile/teammigration/step4/TeamMigrationDoneStepScreen.kt # app/src/main/res/values/strings.xml
# Conflicts: # app/src/main/kotlin/com/wire/android/ui/userprofile/teammigration/TeamMigrationScreen.kt # app/src/main/kotlin/com/wire/android/ui/userprofile/teammigration/TeamMigrationViewModel.kt
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3552 +/- ##
===========================================
+ Coverage 45.21% 45.34% +0.13%
===========================================
Files 472 472
Lines 15765 15790 +25
Branches 2633 2633
===========================================
+ Hits 7128 7160 +32
+ Misses 7887 7880 -7
Partials 750 750
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Built wire-android-staging-compat-pr-3552.apk is available for download |
Built wire-android-dev-debug-pr-3552.apk is available for download |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it with debug mode. We have empty implementation for analytics for non production builds. Maybe we want to add some implementation with prints for easier verification if right analytics actions are called?
# Conflicts: # app/src/main/kotlin/com/wire/android/ui/userprofile/self/SelfUserProfileViewModel.kt # app/src/test/kotlin/com/wire/android/ui/userprofile/self/SelfUserProfileViewModelArrangement.kt # core/analytics/src/main/kotlin/com/wire/android/feature/analytics/model/AnalyticsEvent.kt
Quality Gate passedIssues Measures |
Built wire-android-staging-compat-pr-3552.apk is available for download |
Built wire-android-dev-debug-pr-3552.apk is available for download |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Description
Report events related to team migration according to the accetence creteria defined here
https://wearezeta.atlassian.net/browse/WPB-11318
Needs releases with:
Testing
Test Coverage (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.