fix: black screen when last caller in a group #WPB-10652

[damian-kaczmarek]

WPB-10652 [Android] calling PiP mode

What's new in this PR?

Issues

Couldn't reproduce the original issue but was able to reproduce black screen in following scenario:

• call to a group from account A
• join to call with account B
• enable video on account A
• leave the call with account B
• user A was left with a black screen instead of their own camera preview

Causes (Optional)

There was assumption that on list of participants first account is user currently logged it. Based on that first() was called. This was no longer true with picture in picture enabled as self participant was then removed.

Solutions

Used currently logged in UserId and compared it to a participant to decide if given call tile is selfUser.

Testing

How to Test

• call to a group from account A
• join to call with account B
• enable video on account A
• leave the call with account B
• user A should see own preview video

Attachments (Optional)

Before:

before.mp4

After:

after.mp4

---

PR Post Submission Checklist for internal contributors (Optional)

• Wire's Github Workflow has automatically linked the PR to a JIRA issue

---

PR Post Merge Checklist for internal contributors

• If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

---

References

1. https://sparkbox.com/foundry/semantic_commit_messages
2. https://github.com/wireapp/.github#usage
3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

[ohassine]

Good catch! but Picture in picture feature is not release yet. We can merge this one into develop and assign this ticket WPB-10652 instead to it. (WPB-11117 looks different this PR)

[pull-request-size]

Ups 🫰🟨

This PR is too big. Please try to break it up into smaller PRs.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 45.33%. Comparing base (8501ad1) to head (29ba8c6).

Files with missing lines	Patch %	Lines
...g/ongoing/participantsview/VerticalCallingPager.kt	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #3550   +/-   ##
========================================
  Coverage    45.33%   45.33%           
========================================
  Files          472      472           
  Lines        15795    15795           
  Branches      2632     2632           
========================================
  Hits          7161     7161           
  Misses        7884     7884           
  Partials       750      750           

Files with missing lines	Coverage Δ
...going/participantsview/gridview/CallingGridView.kt	0.00% <ø> (ø)
...g/ongoing/participantsview/VerticalCallingPager.kt	0.00% <0.00%> (ø)

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8501ad1...29ba8c6. Read the comment docs.

[github-actions]

Built wire-android-staging-compat-pr-3550.apk is available for download

[github-actions]

Built wire-android-dev-debug-pr-3550.apk is available for download

[sonarcloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud