Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: show sync retry state for internal build #WPB-11198 #3505

Merged
merged 8 commits into from
Oct 22, 2024
Merged

feat: show sync retry state for internal build #WPB-11198 #3505

merged 8 commits into from
Oct 22, 2024

Conversation

damian-kaczmarek
Copy link
Contributor

@damian-kaczmarek damian-kaczmarek commented Oct 15, 2024 •
edited
Loading

StoryWPB-11198 [Android] indicate sync retry state in the app top bar

What's new in this PR?

Issues

Add more debug info in top bar when sync is waiting for the network. This is only available on internal builds.

Solutions

  • add delay to fail message state
  • top bar listens for network observer state

Dependencies (Optional)

Needs releases with:

Testing

How to Test

Disconnect from internet and run the app

Attachments (Optional)

Before After
image image

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.
References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@damian-kaczmarek damian-kaczmarek self-assigned this Oct 15, 2024
@damian-kaczmarek damian-kaczmarek mentioned this pull request Oct 15, 2024
Merged
3 tasks
@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.31%. Comparing base (90262c3) to head (f5bddae).
Report is 27 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #3505   +/-   ##
========================================
  Coverage    45.31%   45.31%           
========================================
  Files          470      470           
  Lines        15710    15710           
  Branches      2629     2629           
========================================
  Hits          7119     7119           
  Misses        7844     7844           
  Partials       747      747

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90262c3...f5bddae. Read the comment docs.

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-compat-pr-3505.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-dev-debug-pr-3505.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-compat-pr-3505.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-dev-debug-pr-3505.apk is available for download

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 22, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-compat-pr-3505.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-dev-debug-pr-3505.apk is available for download

@damian-kaczmarek damian-kaczmarek added this pull request to the merge queue Oct 22, 2024
Merged via the queue into develop with commit 562a406 Oct 22, 2024
17 checks passed
@damian-kaczmarek damian-kaczmarek deleted the feat/show-sync-retry-state branch October 22, 2024 09:54
@echoes-hq echoes-hq bot added the echoes: features End-user visible changes intended to create customer value label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Garzas Garzas Garzas approved these changes

@borichellow borichellow borichellow approved these changes

@ohassine ohassine Awaiting requested review from ohassine

@saleniuk saleniuk Awaiting requested review from saleniuk

@m-zagorski m-zagorski Awaiting requested review from m-zagorski

@MohamadJaara MohamadJaara Awaiting requested review from MohamadJaara

Assignees

@damian-kaczmarek damian-kaczmarek

Labels
echoes: features End-user visible changes intended to create customer value size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@damian-kaczmarek @codecov-commenter @borichellow @Garzas