fix: run WireViewModel usecases on worker thread (WPB-6874) #3100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… lazy-inject-wire-viewmodel
|
Built wire-android-staging-release-pr-3100.apk is available for download |
|
Built wire-android-dev-debug-pr-3100.apk is available for download |
|
Build 5303 succeeded. The build produced the following APK's: |
…rker-thread # Conflicts: # app/src/main/kotlin/com/wire/android/ui/WireActivityViewModel.kt # app/src/test/kotlin/com/wire/android/ui/WireActivityViewModelTest.kt
ohassine
requested review from
a team,
typfel,
alexandreferris,
MohamadJaara,
mchenani and
Garzas
and removed request for
a team
|
|
Built wire-android-staging-release-pr-3100.apk is available for download |
|
Built wire-android-dev-debug-pr-3100.apk is available for download |
|
Build 5311 succeeded. The build produced the following APK's: |
alexandreferris
approved these changes
Jun 17, 2024
Garzas
approved these changes
Jun 18, 2024
|
echoes-hq
bot
added
the
echoes: maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
After making use cases being injected lazily in #3096 which helped reducing disk violations, we need to make sure that those use cases are created on background thread
Solutions
This PR cleans all remaining disk violation that we have on app startup
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.