Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multiple undo tap for drawing, unnecessary recompositions (WPB-8810) #3032

Merged
merged 1 commit into from
May 24, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented May 23, 2024

BugWPB-8810 [Android] Sketcher Undo button works on 3rd tap


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

We are doing unnecessary recompositions, and we are not using immutable lists.

Causes (Optional)

Sometimes, we need to tap the undo button many times for the same line.

Solutions

Make use of immutable collections, and mark state as stable too, to help the compiler.
Add tests coverage for this case.

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Draw lines and see if it is necessary to tap many undos.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina requested review from Garzas and a team May 23, 2024 16:08
@yamilmedina yamilmedina self-assigned this May 23, 2024
@yamilmedina yamilmedina requested review from alexandreferris, vitorhugods, mchenani and ohassine and removed request for a team May 23, 2024 16:08
Copy link

sonarcloud bot commented May 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@yamilmedina yamilmedina requested a review from saleniuk May 23, 2024 16:23
Copy link
Contributor

Test Results

928 tests   928 ✅  12m 47s ⏱️
123 suites    0 💤
123 files      0 ❌

Results for commit f16663d.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 4958 succeeded.

The build produced the following APK's:

@yamilmedina yamilmedina enabled auto-merge (squash) May 24, 2024 07:47
@yamilmedina yamilmedina merged commit f5db657 into release/candidate May 24, 2024
15 checks passed
@yamilmedina yamilmedina deleted the fix/multiple-undo branch May 24, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants