Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: GitHub actions upload to s3 testing the theory #3023

Conversation

borichellow
Copy link
Contributor

testing

@borichellow borichellow self-assigned this May 22, 2024
@borichellow borichellow changed the base branch from develop to feat/github-actions-upload-to-s3 May 22, 2024 07:56
@codecov-commenter
Copy link

codecov-commenter commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.00%. Comparing base (846c469) to head (7d186dc).
Report is 2 commits behind head on feat/github-actions-upload-to-s3.

Additional details and impacted files
@@                         Coverage Diff                          @@
##           feat/github-actions-upload-to-s3    #3023      +/-   ##
====================================================================
- Coverage                             44.39%   44.00%   -0.39%     
====================================================================
  Files                                   447      447              
  Lines                                 14559    14547      -12     
  Branches                               2498     2497       -1     
====================================================================
- Hits                                   6463     6401      -62     
- Misses                                 7392     7452      +60     
+ Partials                                704      694      -10     

see 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 846c469...7d186dc. Read the comment docs.

Copy link
Contributor

github-actions bot commented May 22, 2024

Test Results

928 tests   - 4   928 ✅  - 4   9m 29s ⏱️ - 3m 55s
123 suites  - 1     0 💤 ±0 
123 files    - 1     0 ❌ ±0 

Results for commit 7d186dc. ± Comparison against base commit 53546ab.

This pull request removes 4 tests.
com.wire.android.ui.home.settings.privacy.PrivacySettingsViewModelTest ‑ given anonymous usage data is set to false, when setting to true, then correct value is propagated()
com.wire.android.ui.home.settings.privacy.PrivacySettingsViewModelTest ‑ given anonymous usage data is set to true, when setting to false, then correct value is propagated()
com.wire.android.ui.home.settings.privacy.PrivacySettingsViewModelTest ‑ given user opens privacy settings screen, when viewing anonymous usage data, then its value is enabled()
com.wire.android.ui.home.settings.privacy.PrivacySettingsViewModelTest ‑ given user opens privacy settings screen, when viewing anonymous usage data, then its value is not enabled()

♻️ This comment has been updated with latest results.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 4883 succeeded.

The build produced the following APK's:

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 4923 succeeded.

The build produced the following APK's:

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 4936 succeeded.

The build produced the following APK's:

Copy link

sonarcloud bot commented May 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 4940 succeeded.

The build produced the following APK's:

@wireapp wireapp deleted a comment from github-actions bot May 28, 2024
Copy link
Contributor

@yamilmedina yamilmedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a good direction, just left a comment in the ticket with some details we need to address
https://wearezeta.atlassian.net/browse/WPB-8730?focusedCommentId=125018

@borichellow borichellow closed this Jun 4, 2024
@yamilmedina yamilmedina deleted the feat/github-actions-upload-to-s3-testing-the-theory branch July 30, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants