-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: image preview improvements [WPB-8801] #3019
feat: image preview improvements [WPB-8801] #3019
Conversation
Build 4843 failed. |
Build 4846 failed. |
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/multiple-image-preview #3019 +/- ##
===============================================================
- Coverage 44.50% 44.42% -0.08%
===============================================================
Files 447 449 +2
Lines 14548 14558 +10
Branches 2499 2502 +3
===============================================================
- Hits 6474 6467 -7
- Misses 7371 7381 +10
- Partials 703 710 +7
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
APKs built during tests are available here. Scroll down to Artifacts! |
Build 4862 succeeded. The build produced the following APK's: |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
MultipleVisible
SingleVisible
AssetTooLargeDialogState
into oneCheckAssetRestrictionsViewModel
ConversationScreen
formatSize
inDeviceUtil
ImportMediaScreen
ArgsSerializer
to parse return values from screen not supported by compose destinations libraryDependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.