Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: markdown support link reference [WPB-9220] #3018

Merged
merged 3 commits into from
May 21, 2024
Merged

fix: markdown support link reference [WPB-9220] #3018

merged 3 commits into from
May 21, 2024

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented May 21, 2024 •
edited by github-actions bot
Loading

BugWPB-9220 [Android] Crash in markdown parser when last message has invalid node

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

There was unsupported LinkReferenceDefinition node for markdown

Causes (Optional)

Crash

Solutions

  • Handle node and show it as a normal text
  • Don't crash for other unsupported nodes, just log them as an error

@Garzas Garzas requested a review from a team May 21, 2024 10:23
@Garzas Garzas self-assigned this May 21, 2024
@Garzas Garzas requested review from alexandreferris, vitorhugods, mchenani, ohassine and saleniuk and removed request for a team May 21, 2024 10:23
@Garzas Garzas changed the title fix/markdown support link reference [WPB-9220] fix: markdown support link reference [WPB-9220] May 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 21, 2024 •
edited
Loading

Test Results

927 tests   927 ✅  8m 12s ⏱️
123 suites    0 💤
123 files      0 ❌

Results for commit 8daf11c.

♻️ This comment has been updated with latest results.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Garzas Garzas enabled auto-merge (squash) May 21, 2024 10:44
@AndroidBob
Copy link
Collaborator

Build 4842 succeeded.

The build produced the following APK's:

@Garzas Garzas merged commit fd020b2 into release/candidate May 21, 2024
15 checks passed
@Garzas Garzas deleted the fix/markdown-support-link-reference branch May 21, 2024 11:56
github-actions bot pushed a commit that referenced this pull request May 21, 2024
@Garzas @github-actions
fix: markdown support link reference [WPB-9220] (#3018)
398ee12
@github-actions github-actions bot mentioned this pull request May 21, 2024
Merged
4 tasks
@github-actions GitHub Actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saleniuk saleniuk saleniuk approved these changes

@yamilmedina yamilmedina yamilmedina approved these changes

@alexandreferris alexandreferris Awaiting requested review from alexandreferris alexandreferris was automatically assigned from wireapp/android

@vitorhugods vitorhugods Awaiting requested review from vitorhugods vitorhugods was automatically assigned from wireapp/android

@mchenani mchenani Awaiting requested review from mchenani mchenani was automatically assigned from wireapp/android

@ohassine ohassine Awaiting requested review from ohassine ohassine was automatically assigned from wireapp/android

Assignees

@Garzas Garzas

Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Garzas @AndroidBob @yamilmedina @saleniuk