Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bring back 'show password' button on password text input #3017

Merged
merged 2 commits into from
May 21, 2024

Conversation

saleniuk
Copy link
Contributor


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

After updating text fields to v2, "show password" button (the one with eye icon) is missing on password text fields.

Solutions

Bring it back.

Testing

How to Test

Open login screen and enter a password.

Attachments (Optional)

Before After
Screenshot_20240521_093459 Screenshot_20240521_095239

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@saleniuk saleniuk requested review from a team, typfel, yamilmedina, borichellow, MohamadJaara and Garzas and removed request for a team May 21, 2024 08:05
@saleniuk saleniuk enabled auto-merge May 21, 2024 08:29
Copy link

sonarcloud bot commented May 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
12.1% Duplication on New Code

See analysis details on SonarCloud

@saleniuk saleniuk added this pull request to the merge queue May 21, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.20%. Comparing base (4411ffb) to head (38187eb).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3017      +/-   ##
===========================================
- Coverage    44.35%   44.20%   -0.15%     
===========================================
  Files          447      447              
  Lines        14559    14558       -1     
  Branches      2498     2497       -1     
===========================================
- Hits          6457     6435      -22     
- Misses        7399     7427      +28     
+ Partials       703      696       -7     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4411ffb...38187eb. Read the comment docs.

Copy link
Contributor

Test Results

932 tests  ±0   932 ✅ ±0   8m 13s ⏱️ +19s
124 suites ±0     0 💤 ±0 
124 files   ±0     0 ❌ ±0 

Results for commit 38187eb. ± Comparison against base commit 4411ffb.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Merged via the queue into develop with commit 2b4b52e May 21, 2024
12 of 13 checks passed
@saleniuk saleniuk deleted the fix/bring-back-show-password-button branch May 21, 2024 09:14
@AndroidBob
Copy link
Collaborator

Build 4828 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants