-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bring back 'show password' button on password text input #3017
Conversation
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3017 +/- ##
===========================================
- Coverage 44.35% 44.20% -0.15%
===========================================
Files 447 447
Lines 14559 14558 -1
Branches 2498 2497 -1
===========================================
- Hits 6457 6435 -22
- Misses 7399 7427 +28
+ Partials 703 696 -7 see 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
APKs built during tests are available here. Scroll down to Artifacts! |
Build 4828 succeeded. The build produced the following APK's: |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
After updating text fields to v2, "show password" button (the one with eye icon) is missing on password text fields.
Solutions
Bring it back.
Testing
How to Test
Open login screen and enter a password.
Attachments (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.