-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: recreate cache directories in case cache is cleared [WPB-7368] 🍒 #3016
fix: recreate cache directories in case cache is cleared [WPB-7368] 🍒 #3016
Conversation
…-directories-when-cleared-cherry-pick
APKs built during tests are available here. Scroll down to Artifacts! |
Build 4820 succeeded. The build produced the following APK's: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3016 +/- ##
========================================
Coverage 44.25% 44.26%
========================================
Files 448 448
Lines 14519 14517 -2
Branches 2495 2493 -2
========================================
Hits 6426 6426
+ Misses 7391 7388 -3
- Partials 702 703 +1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
APKs built during tests are available here. Scroll down to Artifacts! |
Build 4917 succeeded. The build produced the following APK's: |
…-directories-when-cleared-cherry-pick
…hen-cleared-cherry-pick' into fix/recreate-cache-directories-when-cleared-cherry-pick
Quality Gate passedIssues Measures |
APKs built during tests are available here. Scroll down to Artifacts! |
Build 4926 failed. |
This PR was manually cherry-picked based on the following PR (automatic cherry pick failed):
Original PR description:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
We get multiple crashes when accessing cache files (ENOENT errors) which potentially suggest that the cache is fully cleared and the app cannot find needed directories for the given user in cache to create a temporary file for that user.
Solutions
Refactor code to have only single source of temporary file paths -
kaliumFileSystem.tempFilePath
, and use updated kalium version where cache directories are being recreated when getting a temporary cache file path in case cache is cleared.Dependencies (Optional)
Needs releases with:
Testing
How to Test
Open the app, clear app cache and try to send or download asset.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.