Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add new verified string for opt-out toggle description (WPB-8922) #3011

Merged
merged 1 commit into from
May 16, 2024

Conversation

alexandreferris
Copy link
Contributor

@alexandreferris alexandreferris commented May 16, 2024

TaskWPB-8922 [Android] Add a toggle to opt out of sending analytics data


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Description for opt-out toggle of analytics had some typos.
: Usage data allow Wire to understand how the app is being used, and how it can be improved. The data is anonymous and doesn’t contains the content of your communications (such as messages, files, location, or calls)

Solutions

Add new correct string.

: Usage data allows Wire to understand how the app is being used and how it can be improved. The data is anonymous and does not include the content of your communications (such as messages, files, locations, or calls).

@alexandreferris alexandreferris self-assigned this May 16, 2024
@alexandreferris alexandreferris requested review from a team, yamilmedina, borichellow, MohamadJaara, vitorhugods and saleniuk and removed request for a team May 16, 2024 07:59
Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

github-actions bot commented May 16, 2024

Test Results

932 tests  ±0   932 ✅ ±0   8m 33s ⏱️ - 7m 4s
124 suites ±0     0 💤 ±0 
124 files   ±0     0 ❌ ±0 

Results for commit 92c3bc6. ± Comparison against base commit 0cd5009.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 4776 succeeded.

The build produced the following APK's:

@codecov-commenter
Copy link

codecov-commenter commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.35%. Comparing base (0cd5009) to head (92c3bc6).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3011      +/-   ##
===========================================
+ Coverage    44.31%   44.35%   +0.03%     
===========================================
  Files          447      447              
  Lines        14558    14559       +1     
  Branches      2497     2498       +1     
===========================================
+ Hits          6452     6457       +5     
+ Misses        7403     7399       -4     
  Partials       703      703              

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cd5009...92c3bc6. Read the comment docs.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Copy link
Contributor

@Garzas Garzas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not acceptable 😂

app/src/main/res/values/strings.xml Show resolved Hide resolved
@Garzas Garzas self-requested a review May 16, 2024 12:49
@alexandreferris alexandreferris added this pull request to the merge queue May 16, 2024
Merged via the queue into develop with commit d4ec2b5 May 16, 2024
16 checks passed
@alexandreferris alexandreferris deleted the chore/update_optout_toggle_description branch May 16, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants