feat: Github actions upload to S3 #3009
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3009 +/- ##
===========================================
+ Coverage 44.00% 44.35% +0.34%
===========================================
Files 447 447
Lines 14547 14559 +12
Branches 2497 2498 +1
===========================================
+ Hits 6402 6457 +55
+ Misses 7451 7399 -52
- Partials 694 703 +9 see 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 4759 succeeded. The build produced the following APK's: |
There was a problem hiding this comment.
Good to see this becoming a reality 🥇
We might want to consider, using this action instead (suggestion) https://github.com/marketplace/actions/s3-upload-action
As provides as well a way to post the URL back to the PR, like we are doing today with Jenknins, ie. #3009 (comment)
.github/workflows/upload-aws-s3.yml
Outdated
| with: | ||
| args: --acl public-read --follow-symlinks --delete | ||
| env: | ||
| AWS_S3_BUCKET: "z-lohika" |
There was a problem hiding this comment.
We can use here AWS_S3_BUCKET added it to the repo too as a secret
.github/workflows/upload-aws-s3.yml
Outdated
| steps: | ||
| - uses: jakejarvis/s3-sync-action@master | ||
| with: | ||
| args: --acl public-read --follow-symlinks --delete |
There was a problem hiding this comment.
I didn't check, but we should keep private
.github/workflows/upload-aws-s3.yml
Outdated
| args: --acl public-read --follow-symlinks --delete | ||
| env: | ||
| AWS_S3_BUCKET: "z-lohika" | ||
| DEST_DIR: "megazord/android/reloaded/${params.FLAVOR.toLowerCase()}/${params.BUILD_TYPE.toLowerCase()}/" |
There was a problem hiding this comment.
As I understand from here
We should upload the APK to the path you use correctly in the PR, plus this other one as well (depending on this
if (params.SOURCE_BRANCH.startsWith("PR-") || params.SOURCE_BRANCH == "develop" || params.SOURCE_BRANCH == "release/candidate")
To (note the by-branch prefix)
path: "megazord/android/reloaded/by-branch/${params.SOURCE_BRANCH}/${params.FLAVOR.toLowerCase()}/${params.BUILD_TYPE.toLowerCase()}/"
|
Build 4790 succeeded. The build produced the following APK's: |
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 4797 succeeded. The build produced the following APK's: |
| ./gradlew assembleStagingCompat -p ./ --no-daemon | ||
| - name: Upload APK staging compat | ||
| if: success() | ||
| uses: ./.github/workflows/upload-aws-s3.yml |
There was a problem hiding this comment.
Can you try to use, just for testing purposes, I have the feeling this is a temporary problem, and might be solved after merge to the default branch (develop)
| uses: ./.github/workflows/upload-aws-s3.yml | |
| uses: ./.github/workflows/upload-aws-s3.yml@feat/github-actions-upload-to-s3 |
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 4799 succeeded. The build produced the following APK's: |
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 4838 succeeded. The build produced the following APK's: |
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 4841 succeeded. The build produced the following APK's: |
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 4861 succeeded. The build produced the following APK's: |
|
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 4867 succeeded. The build produced the following APK's: |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Briefly describe the issue you have solved or implemented with this pull request. If the PR contains multiple issues, use a bullet list.
Causes (Optional)
Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.
Solutions
Briefly describe the solutions you have implemented for the issues explained above.
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.