Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add toggle to opt-out analytics (WPB-8922) #3008

Merged
merged 7 commits into from
May 15, 2024

Conversation

alexandreferris
Copy link
Contributor

@alexandreferris alexandreferris commented May 15, 2024

TaskWPB-8922 [Android] Add a toggle to opt out of sending analytics data


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

There was no implementation of a switch button to opt-out of analytics in privacy settings screen

Solutions

Add switch button to opt-out of analytics
Added the enabled/disabled value into GlobalDataStore for now until we have more information on how we can propagate its value to other clients.

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

  • Open Settings
  • Open Privacy Settings Screen
  • Analytics Switch button is the first one

Attachments (Optional)

send_anonymous_data

@alexandreferris alexandreferris self-assigned this May 15, 2024
Copy link

sonarcloud bot commented May 15, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

Test Results

932 tests  +4   932 ✅ +4   15m 4s ⏱️ + 4m 57s
124 suites +1     0 💤 ±0 
124 files   +1     0 ❌ ±0 

Results for commit 079ec62. ± Comparison against base commit 24769c4.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@alexandreferris alexandreferris requested review from a team, typfel, mchenani, Garzas, ohassine, saleniuk, yamilmedina, MohamadJaara and vitorhugods and removed request for a team May 15, 2024 14:09
@AndroidBob
Copy link
Collaborator

Build 4758 succeeded.

The build produced the following APK's:

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 44.35%. Comparing base (24769c4) to head (079ec62).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3008      +/-   ##
===========================================
+ Coverage    44.00%   44.35%   +0.34%     
===========================================
  Files          447      447              
  Lines        14547    14559      +12     
  Branches      2497     2498       +1     
===========================================
+ Hits          6402     6457      +55     
+ Misses        7451     7399      -52     
- Partials       694      703       +9     
Files Coverage Δ
...d/ui/home/settings/privacy/PrivacySettingsState.kt 100.00% <100.00%> (+100.00%) ⬆️
.../home/settings/privacy/PrivacySettingsViewModel.kt 49.12% <100.00%> (+49.12%) ⬆️
...tlin/com/wire/android/datastore/GlobalDataStore.kt 25.00% <33.33%> (+0.36%) ⬆️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24769c4...079ec62. Read the comment docs.

@alexandreferris alexandreferris added this pull request to the merge queue May 15, 2024
Merged via the queue into develop with commit e74d567 May 15, 2024
13 checks passed
@alexandreferris alexandreferris deleted the feat/add_toggle_optout_analytics branch May 15, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants