Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add privacy policy (WPB-8846) #3001

Merged
merged 6 commits into from
May 14, 2024
Merged

Conversation

alexandreferris
Copy link
Contributor

@alexandreferris alexandreferris commented May 14, 2024

TaskWPB-8846 [Android] Add privacy policy and terms of use section to Android


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

There was no Privacy Policy / Terms of Use linking from the App Settings.

Causes (Optional)

Not implemented.

Solutions

  • Add a new screen : About this App from the Settings screen (at the bottom)
  • Add Privacy Policy / Terms of Use / Licenses / Current Version GIT commit / Current App Version / Copyright on About this App screen
  • Remove Licenses from Settings screen

Testing

How to Test

  • Open App
  • Open Settings Screen (from top-left menu)
  • Scroll to the bottom and open About this App
  • Should contain items mentioned in Solutions and:
    • Privacy Policy should open on the web
    • Terms of Use should open on the web
    • Licenses should open another screen
    • Git commit / App version should be able to copy to clipboard

Attachments (Optional)

Settings Screen About this App Screen

Copy link
Contributor

github-actions bot commented May 14, 2024

Test Results

928 tests  ±0   928 ✅ ±0   14m 47s ⏱️ + 4m 55s
123 suites ±0     0 💤 ±0 
123 files   ±0     0 ❌ ±0 

Results for commit a1475b7. ± Comparison against base commit 08879d3.

♻️ This comment has been updated with latest results.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@alexandreferris alexandreferris requested review from a team, borichellow, mchenani, Garzas, ohassine and saleniuk and removed request for a team May 14, 2024 10:11
@AndroidBob
Copy link
Collaborator

Build 4729 succeeded.

The build produced the following APK's:

@codecov-commenter
Copy link

codecov-commenter commented May 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 44.24%. Comparing base (08879d3) to head (a1475b7).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3001      +/-   ##
===========================================
- Coverage    44.31%   44.24%   -0.08%     
===========================================
  Files          444      446       +2     
  Lines        14492    14515      +23     
  Branches      2493     2493              
===========================================
  Hits          6422     6422              
- Misses        7369     7392      +23     
  Partials       701      701              
Files Coverage Δ
...ire/android/ui/settings/about/AboutThisAppState.kt 0.00% <0.00%> (ø)
...android/ui/settings/about/AboutThisAppViewModel.kt 0.00% <0.00%> (ø)
.../com/wire/android/ui/home/settings/SettingsItem.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08879d3...a1475b7. Read the comment docs.

Copy link
Contributor

@Garzas Garzas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 🚀

Signed-off-by: alexandreferris <[email protected]>
@alexandreferris alexandreferris added this pull request to the merge queue May 14, 2024
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Merged via the queue into develop with commit bb9e765 May 14, 2024
11 of 12 checks passed
@alexandreferris alexandreferris deleted the feat/add_privacy_policy branch May 14, 2024 12:05
@AndroidBob
Copy link
Collaborator

Build 4732 succeeded.

The build produced the following APK's:

yamilmedina pushed a commit that referenced this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants