refactor: remove rememberRipple, unify calling icon buttons #2998
Conversation
…nify-calling-buttons
saleniuk
requested review from
a team,
typfel,
borichellow,
mchenani,
Garzas and
ohassine
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2998 +/- ##
===========================================
+ Coverage 44.00% 44.15% +0.14%
===========================================
Files 447 447
Lines 14547 14548 +1
Branches 2497 2498 +1
===========================================
+ Hits 6402 6423 +21
+ Misses 7451 7424 -27
- Partials 694 701 +7 see 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 4718 succeeded. The build produced the following APK's: |
…nify-calling-buttons # Conflicts: # app/src/main/kotlin/com/wire/android/ui/calling/controlbuttons/CameraButton.kt # app/src/main/kotlin/com/wire/android/ui/calling/controlbuttons/CameraFlipButton.kt # app/src/main/kotlin/com/wire/android/ui/calling/controlbuttons/DeclineButton.kt # app/src/main/kotlin/com/wire/android/ui/calling/controlbuttons/MicrophoneButton.kt # app/src/main/kotlin/com/wire/android/ui/calling/controlbuttons/SpeakerButton.kt # app/src/main/kotlin/com/wire/android/ui/common/AppExtensions.kt
|
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 4762 succeeded. The build produced the following APK's: |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
When updating compose version, there were some problems with
rememberRippleas it has been updated/changed in the compose library. Having custom ripples set in the app may lead to some wrong colors chosen for the indication or ripple not covering or going beyond the element if the shape is not correct.Solutions
Removed all
rememberRipplein the app, instead rely on the default indication type and colour based on the theme.Added ripple colors to button color scheme to enable setting different ripple colors for different button states in the theme.
Unified all calling icon buttons so that they are consistent, have correct types, reuse the same elements and are in line with designs.
Fixed previews and added some more where missing.
Testing
How to Test
Open calling screens and click on round calling icon buttons.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.