fix: No red shields visible on devices list from other users [WPB-8677] #2977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borichellow
requested review from
yamilmedina,
alexandreferris,
mchenani,
Garzas and
saleniuk
alexandreferris
approved these changes
May 6, 2024
vitorhugods
approved these changes
May 6, 2024
Test Results823 tests 823 ✅ 7m 26s ⏱️ Results for commit dee1408. |
|
APKs built during tests are available here. Scroll down to Artifacts! |
borichellow
deleted the
fix/no_red_shields_visible_on_device_list_from_other_users
branch
|
Build 4629 succeeded. The build produced the following APK's: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR?
Issues
Icons for "Revoked" and "Expired" E2EI certificates are not displayed in DevicesList in OtherUserProfile screen
Causes (Optional)
Were hidden (misunderstanding with designs)
Solutions
Show them when needed