Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: divider thickness [WPB-3985] #2971

Merged
merged 2 commits into from
May 6, 2024
Merged

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented May 6, 2024

BugWPB-3985 [Android] Divider lines are missing in conversation details / options view


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Fixed default thickness for WireDivider

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)

Before After
divider_before divider_after

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@Garzas Garzas enabled auto-merge (squash) May 6, 2024 10:21
Copy link
Contributor

github-actions bot commented May 6, 2024

Test Results

928 tests   928 ✅  16m 49s ⏱️
123 suites    0 💤
123 files      0 ❌

Results for commit 45eea0b.

Copy link
Contributor

github-actions bot commented May 6, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 4612 succeeded.

The build produced the following APK's:

@Garzas Garzas merged commit a16ed45 into release/candidate May 6, 2024
10 of 11 checks passed
@Garzas Garzas deleted the fix/divider-thickness branch May 6, 2024 11:32
github-actions bot pushed a commit that referenced this pull request May 6, 2024
Copy link
Contributor

github-actions bot commented May 6, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 4616 succeeded.

The build produced the following APK's:

@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants