Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keep the composed message when replying [WPB-982] #2969

Merged

Conversation

vitorhugods
Copy link
Member

@vitorhugods vitorhugods commented May 3, 2024

StoryWPB-982 Swipe right to reply to a message


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

When a user types something and then decides to reply to a message, the current text input is cleared and the user needs to type everything again.

This affects both swiping to reply and long-click on message -> reply.

Solutions

When replying, do not clear the text.

Testing

Test Coverage

  • I have added automated test to this contribution

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@vitorhugods vitorhugods requested review from a team, typfel, yamilmedina, alexandreferris, borichellow and mchenani and removed request for a team May 3, 2024 14:04
@vitorhugods vitorhugods removed the request for review from typfel May 3, 2024 14:04
@vitorhugods vitorhugods enabled auto-merge (squash) May 3, 2024 14:29
@vitorhugods vitorhugods merged commit a0ae53d into release/candidate May 3, 2024
9 of 10 checks passed
@vitorhugods vitorhugods deleted the fix/keep-the-composed-message-when-replying branch May 3, 2024 14:50
Copy link
Contributor

github-actions bot commented May 3, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 4605 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants