Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: finish CallActivity and remove task when call is terminated (WPB-6437) #2963

Merged
merged 5 commits into from
May 3, 2024

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented May 3, 2024

TaskWPB-6437 Move calling UIs to be displayed on a separate activity


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

  • When call is terminated, user can get back to the callActivity from recent tasks.
  • We are killing the activity for incoming&outgoing call screen when minimizing the screen.

Solutions

  • We need to finish callActivity and remove the task as well when call is ended.
  • Minimize the screen by calling moveTaskToBack() instead finishing callActivity

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine requested review from a team, typfel, yamilmedina, MohamadJaara, Garzas and saleniuk and removed request for a team May 3, 2024 09:13
@ohassine ohassine enabled auto-merge (squash) May 3, 2024 09:59
@AndroidBob
Copy link
Collaborator

Build 4578 succeeded.

The build produced the following APK's:

Copy link
Contributor

github-actions bot commented May 3, 2024

Test Results

927 tests   927 ✅  14m 13s ⏱️
123 suites    0 💤
123 files      0 ❌

Results for commit 533da7f.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented May 3, 2024

APKs built during tests are available here. Scroll down to Artifacts!

Copy link
Contributor

github-actions bot commented May 3, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@ohassine ohassine merged commit 933883e into release/candidate May 3, 2024
10 of 11 checks passed
@ohassine ohassine deleted the fix-call-terminated branch May 3, 2024 12:51
Copy link
Contributor

github-actions bot commented May 3, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 4599 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants