Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(e2ei): download certificate name (WPB-8606) #2961

Merged
merged 7 commits into from
May 6, 2024

Conversation

mchenani
Copy link
Contributor

@mchenani mchenani commented May 3, 2024

BugWPB-8606 [Android] When downloading another users certificate, saved file has wrong name


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Set the userHandle exposed with E2EI as the certificate download file.

Issues

Wrong userHandle was set, the current userHandle was set as the file name.

Causes (Optional)

Miss implementation.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented May 3, 2024

Test Results

823 tests   823 ✅  11m 6s ⏱️
110 suites    0 💤
110 files      0 ❌

Results for commit 5a633e2.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 4572 failed.

@AndroidBob
Copy link
Collaborator

Build 4588 failed.

Copy link
Contributor

github-actions bot commented May 3, 2024

@mchenani looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (release/cycle-4.6) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

release/cycle-4.6 This PR
d7dccb817696a857789954977725a49b2c253d2a a1fdb7faa6566154e3ea48adb5bcb41634722083

Is this intentional?

Copy link
Contributor

github-actions bot commented May 3, 2024

@mchenani looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (release/cycle-4.6) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

release/cycle-4.6 This PR
d7dccb817696a857789954977725a49b2c253d2a a1fdb7faa6566154e3ea48adb5bcb41634722083

Is this intentional?

@AndroidBob
Copy link
Collaborator

Build 4595 failed.

Copy link
Contributor

github-actions bot commented May 3, 2024

@mchenani looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (release/cycle-4.6) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

release/cycle-4.6 This PR
d7dccb817696a857789954977725a49b2c253d2a a1fdb7faa6566154e3ea48adb5bcb41634722083

Is this intentional?

Copy link
Contributor

github-actions bot commented May 3, 2024

@mchenani looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (release/cycle-4.6) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

release/cycle-4.6 This PR
d7dccb817696a857789954977725a49b2c253d2a a1fdb7faa6566154e3ea48adb5bcb41634722083

Is this intentional?

Copy link
Contributor

github-actions bot commented May 3, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 4603 succeeded.

The build produced the following APK's:

@mchenani mchenani merged commit c184481 into release/cycle-4.6 May 6, 2024
13 checks passed
@mchenani mchenani deleted the fix/download-certificate-name branch May 6, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants