-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(e2ei): download certificate name (WPB-8606) #2961
Conversation
Test Results823 tests 823 ✅ 11m 6s ⏱️ Results for commit 5a633e2. ♻️ This comment has been updated with latest results. |
Build 4572 failed. |
Build 4588 failed. |
@mchenani looks like you are rolling back kalium to a previous commitish. This means that the PR's target branch (release/cycle-4.6) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.
Is this intentional? |
@mchenani looks like you are rolling back kalium to a previous commitish. This means that the PR's target branch (release/cycle-4.6) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.
Is this intentional? |
Build 4595 failed. |
…nto fix/download-certificate-name
@mchenani looks like you are rolling back kalium to a previous commitish. This means that the PR's target branch (release/cycle-4.6) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.
Is this intentional? |
@mchenani looks like you are rolling back kalium to a previous commitish. This means that the PR's target branch (release/cycle-4.6) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.
Is this intentional? |
APKs built during tests are available here. Scroll down to Artifacts! |
Build 4603 succeeded. The build produced the following APK's: |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Set the userHandle exposed with E2EI as the certificate download file.
Issues
Wrong userHandle was set, the current userHandle was set as the file name.
Causes (Optional)
Miss implementation.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.