-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow swipe to reply (WPB-982) #2955
Conversation
Users can swipe a message to the start of the screen in order to reply to it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀🚀
Test Results922 tests 922 ✅ 10m 17s ⏱️ Results for commit b026f88. |
APKs built during tests are available here. Scroll down to Artifacts! |
APKs built during tests are available here. Scroll down to Artifacts! |
Build 4557 succeeded. The build produced the following APK's: |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Self explanatory, innit?
Solutions
Use SwipeToDismissBoxState.
Extracted the whole drag animation logic and icon setup into
SwipableToReplyBox
. It can be modified to allow swiping to multiple directions with different actions later on.Testing
Not really testable at the moment. It's all UI.
Attachments
Light and Dark theme usage
Swipe.to.Reply.mp4
Back gesture support
Edge.margin.mp4
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.