Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow swipe to reply (WPB-982) #2955

Merged
merged 9 commits into from
May 2, 2024

Conversation

vitorhugods
Copy link
Member

@vitorhugods vitorhugods commented May 2, 2024

StoryWPB-982 Swipe right to reply to a message


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Self explanatory, innit?

Solutions

Use SwipeToDismissBoxState.

  • Always reject state changes, so after the drag animation it goes back to settled.

Extracted the whole drag animation logic and icon setup into SwipableToReplyBox. It can be modified to allow swiping to multiple directions with different actions later on.

Testing

Not really testable at the moment. It's all UI.

Attachments

Light and Dark theme usage

Swipe.to.Reply.mp4

Back gesture support

Edge.margin.mp4

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@vitorhugods vitorhugods requested review from a team, typfel, MohamadJaara, Garzas, ohassine and saleniuk and removed request for a team May 2, 2024 12:39
@vitorhugods vitorhugods requested review from yamilmedina and alexandreferris and removed request for typfel May 2, 2024 12:40
Copy link
Member

@ohassine ohassine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀

Copy link
Contributor

github-actions bot commented May 2, 2024

Test Results

922 tests   922 ✅  10m 17s ⏱️
123 suites    0 💤
123 files      0 ❌

Results for commit b026f88.

Copy link
Contributor

github-actions bot commented May 2, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@vitorhugods vitorhugods enabled auto-merge (squash) May 2, 2024 13:57
@vitorhugods vitorhugods merged commit 2c01aaa into release/candidate May 2, 2024
10 of 11 checks passed
@vitorhugods vitorhugods deleted the feat/allow-swipe-to-reply branch May 2, 2024 14:29
github-actions bot added a commit that referenced this pull request May 2, 2024
Copy link
Contributor

github-actions bot commented May 2, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 4557 succeeded.

The build produced the following APK's:

vitorhugods added a commit that referenced this pull request May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants