Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: start CallActivity in a new task (WPB-6437) #2952

Merged
merged 3 commits into from
May 2, 2024

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Apr 30, 2024

TaskWPB-6437 Move calling UIs to be displayed on a separate activity


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Currently we need to finish the activity to minimise the screen which is resource consumer.

Solutions

  • Start CallActivity in a new task so we don't need to re-create the activity(with its renderers when video is enabled) when it was minimised.
  • Fixed a memory leak

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine requested review from a team, yamilmedina, borichellow, MohamadJaara, Garzas and saleniuk and removed request for a team April 30, 2024 14:36
Copy link
Contributor

github-actions bot commented Apr 30, 2024

Test Results

924 tests  ±0   924 ✅ ±0   10m 12s ⏱️ - 2m 51s
123 suites ±0     0 💤 ±0 
123 files   ±0     0 ❌ ±0 

Results for commit 4c01401. ± Comparison against base commit d099c02.

♻️ This comment has been updated with latest results.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 4538 succeeded.

The build produced the following APK's:

@ohassine ohassine changed the base branch from develop to release/candidate May 2, 2024 13:03
@pull-request-size pull-request-size bot added size/S and removed size/XS labels May 2, 2024
@ohassine ohassine changed the base branch from release/candidate to develop May 2, 2024 13:03
@pull-request-size pull-request-size bot added size/XS and removed size/S labels May 2, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 44.19%. Comparing base (d099c02) to head (4c01401).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2952      +/-   ##
===========================================
- Coverage    44.25%   44.19%   -0.06%     
===========================================
  Files          444      444              
  Lines        14458    14455       -3     
  Branches      2476     2475       -1     
===========================================
- Hits          6399     6389      -10     
- Misses        7364     7373       +9     
+ Partials       695      693       -2     
Files Coverage Δ
.../wire/android/ui/calling/SharedCallingViewModel.kt 63.15% <ø> (-0.16%) ⬇️
...kotlin/com/wire/android/ui/calling/CallActivity.kt 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d099c02...4c01401. Read the comment docs.

@ohassine ohassine enabled auto-merge May 2, 2024 13:25
@ohassine ohassine added this pull request to the merge queue May 2, 2024
Copy link
Contributor

github-actions bot commented May 2, 2024

APKs built during tests are available here. Scroll down to Artifacts!

Merged via the queue into develop with commit 6142d0a May 2, 2024
11 of 12 checks passed
@ohassine ohassine deleted the start-call-activity-in-a-new-task branch May 2, 2024 13:57
@AndroidBob
Copy link
Collaborator

Build 4549 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants