Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: text changes for the new group creation flow [WPB-1630] #2947

Merged
merged 3 commits into from
Apr 29, 2024

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Apr 29, 2024

StoryWPB-1630 Create new group conversation (new flow)


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Some texts on the new group creation flow are not updated according to the new designs for this flow.

Solutions

Updated texts.

Testing

How to Test

Create a new group.

Attachments (Optional)

Before After
create_group_flow_before.mp4
create_group_flow_after.mp4

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@saleniuk saleniuk requested review from a team, typfel, alexandreferris, vitorhugods, mchenani and ohassine and removed request for a team April 29, 2024 08:59
@saleniuk saleniuk enabled auto-merge April 29, 2024 09:04
Copy link
Contributor

github-actions bot commented Apr 29, 2024

Test Results

916 tests  ±0   916 ✅ ±0   13m 50s ⏱️ + 4m 10s
123 suites ±0     0 💤 ±0 
123 files   ±0     0 ❌ ±0 

Results for commit 8a5a6c0. ± Comparison against base commit b0043db.

♻️ This comment has been updated with latest results.

@saleniuk saleniuk added this pull request to the merge queue Apr 29, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.23%. Comparing base (b0043db) to head (8a5a6c0).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2947      +/-   ##
===========================================
+ Coverage    44.01%   44.23%   +0.21%     
===========================================
  Files          444      444              
  Lines        14358    14359       +1     
  Branches      2469     2470       +1     
===========================================
+ Hits          6319     6351      +32     
+ Misses        7354     7315      -39     
- Partials       685      693       +8     

see 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0043db...8a5a6c0. Read the comment docs.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Merged via the queue into develop with commit 70f61a5 Apr 29, 2024
11 of 12 checks passed
@saleniuk saleniuk deleted the fix/new-group-flow-ux-fixes branch April 29, 2024 10:10
@AndroidBob
Copy link
Collaborator

Build 4509 succeeded.

The build produced the following APK's:

@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants