-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: text changes for the new group creation flow [WPB-1630] #2947
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2947 +/- ##
===========================================
+ Coverage 44.01% 44.23% +0.21%
===========================================
Files 444 444
Lines 14358 14359 +1
Branches 2469 2470 +1
===========================================
+ Hits 6319 6351 +32
+ Misses 7354 7315 -39
- Partials 685 693 +8 see 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
APKs built during tests are available here. Scroll down to Artifacts! |
Build 4509 succeeded. The build produced the following APK's: |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Some texts on the new group creation flow are not updated according to the new designs for this flow.
Solutions
Updated texts.
Testing
How to Test
Create a new group.
Attachments (Optional)
create_group_flow_before.mp4
create_group_flow_after.mp4
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.