Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: empty html message #2943

Merged
merged 2 commits into from
Apr 26, 2024
Merged

fix: empty html message #2943

merged 2 commits into from
Apr 26, 2024

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Apr 26, 2024


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

Fixed unsupported html message to be showed as normal paragraph with inline text

@Garzas Garzas self-assigned this Apr 26, 2024
@Garzas Garzas requested review from a team, alexandreferris, mchenani, ohassine and saleniuk and removed request for a team April 26, 2024 13:56
@Garzas Garzas enabled auto-merge April 26, 2024 13:56
Copy link
Member

@vitorhugods vitorhugods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SIDE-NOTE, NOT TO BE SEEN BY THE MEERKAT POLICE 🚔🚨

But it would be great to have snapshot testing for Markdown rendering. As there's no testing for this at the moment. We could catch some bugs like that.

Copy link
Contributor

github-actions bot commented Apr 26, 2024

Test Results

912 tests  ±0   912 ✅ ±0   12m 42s ⏱️ - 3m 28s
123 suites ±0     0 💤 ±0 
123 files   ±0     0 ❌ ±0 

Results for commit e2f4dba. ± Comparison against base commit 790f8b2.

♻️ This comment has been updated with latest results.

@Garzas
Copy link
Contributor Author

Garzas commented Apr 26, 2024

SIDE-NOTE, NOT TO BE SEEN BY THE MEERKAT POLICE 🚔🚨

But it would be great to have snapshot testing for Markdown rendering. As there's no testing for this at the moment. We could catch some bugs like that.

@vitorhugods

I'm working on it undercover 🕵️‍♂️

@Garzas Garzas added this pull request to the merge queue Apr 26, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 44.17%. Comparing base (790f8b2) to head (e2f4dba).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2943      +/-   ##
===========================================
- Coverage    44.18%   44.17%   -0.01%     
===========================================
  Files          443      443              
  Lines        14339    14341       +2     
  Branches      2468     2468              
===========================================
  Hits          6335     6335              
- Misses        7311     7313       +2     
  Partials       693      693              
Files Coverage Δ
...lin/com/wire/android/ui/markdown/MarkdownHelper.kt 43.13% <0.00%> (-0.43%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 790f8b2...e2f4dba. Read the comment docs.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Merged via the queue into develop with commit d4e1cd6 Apr 26, 2024
11 of 12 checks passed
@Garzas Garzas deleted the fix/empty-html-message branch April 26, 2024 14:55
@AndroidBob
Copy link
Collaborator

Build 4488 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants