Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: request video streams after creating renderers (WPB-8808) #2939

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Apr 25, 2024

BugWPB-8808 [Android] Videos in call UI are shown as black until I minimise the call and come back


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Sometimes when we join a call we see others video as a black frame

Causes (Optional)

We are requesting video stream before creating the renderer

Solutions

Move requesting video stream part to be done after creating participants tiles

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine requested review from a team, yamilmedina, borichellow, MohamadJaara, vitorhugods and saleniuk and removed request for a team April 25, 2024 15:32
Copy link
Contributor

Test Results

909 tests  ±0   909 ✅ ±0   15m 49s ⏱️ +32s
123 suites ±0     0 💤 ±0 
123 files   ±0     0 ❌ ±0 

Results for commit c0caef0. ± Comparison against base commit 838c9b6.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 4468 succeeded.

The build produced the following APK's:

@@ -117,6 +109,14 @@ fun VerticalCallingPager(
onDoubleTap = onDoubleTap
)
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add a code comment here that the requestVideoStreams should be called after creating renderers

@ohassine ohassine added this pull request to the merge queue Apr 26, 2024
Merged via the queue into develop with commit 790f8b2 Apr 26, 2024
13 checks passed
@ohassine ohassine deleted the delay-requesting-video-stream branch April 26, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants