chore: replace deprecated functions #2931
Conversation
ohassine
changed the title
ohassine
requested review from
a team,
typfel,
yamilmedina,
borichellow,
MohamadJaara and
vitorhugods
and removed request for
a team
| @@ -100,12 +100,12 @@ fun MLSProgressIndicator( | |||
| contentAlignment = Alignment.Center | |||
| ) { | |||
| LinearProgressIndicator( | |||
| progress = progress, | |||
| progress = { progress }, | |||
There was a problem hiding this comment.
I wonder if passing this as lambda will cause unnecessary recomposition?
There was a problem hiding this comment.
Actually it's the opposite, using the lambda will prevent recomposition. If progress value changes then only the lambda function will re-run not all the screen
There was a problem hiding this comment.
not really, a new state value a composition for the whole screen and when evaluating lambda objects it will always not be equal in this case (even if the value of progress did not change)
i can be wrong tho
There was a problem hiding this comment.
The read of the value will be done in the child composable, so it won't effect as explained here
https://youtu.be/ahXLwg2JYpc?t=356
And the current one is deprecated: "Use the overload that takes progress as a lambda "
app/src/main/kotlin/com/wire/android/ui/userprofile/other/OtherUserDevicesScreen.kt
Outdated
Show resolved
Hide resolved
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 4398 succeeded. The build produced the following APK's: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2931 +/- ##
===========================================
+ Coverage 44.09% 44.15% +0.06%
===========================================
Files 442 442
Lines 14302 14298 -4
Branches 2458 2457 -1
===========================================
+ Hits 6306 6313 +7
+ Misses 7305 7294 -11
Partials 691 691
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
Build 4414 failed. |
|
Build 4424 failed. |
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 4441 succeeded. The build produced the following APK's: |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Replacing deprecated functions and some cleanup 🧹
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.