Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): separate lower KeyPackage limit and set to false (WPB-8685) #2930

Conversation

AndroidBob
Copy link
Collaborator

@AndroidBob AndroidBob commented Apr 23, 2024

TaskWPB-8685 [Android] Increase keypackages amount to 100 again on all builds

Cherry pick from the original PR:


⚠️ Conflicts during cherry-pick:
kalium


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Introducing dedicated config flag for LoweringKeypackagesLimit and set to as default.

Issues

The QA needs to have loweringKeyPackages in different builds configurable,


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. .

@AndroidBob AndroidBob added the cherry-pick PR is cherry-picking changes from another banch label Apr 23, 2024
Copy link
Contributor

Test Results

22 tests   - 881   22 ✅  - 881   0s ⏱️ - 9m 57s
 5 suites  - 118    0 💤 ±  0 
 5 files    - 118    0 ❌ ±  0 

Results for commit b3e4826. ± Comparison against base commit 114d60a.

This pull request removes 881 tests.
com.wire.android.GlobalObserversManagerTest ‑ given app not visible and valid session, when handling ephemeral messages, then do not call deleteEphemeralMessageEndDate()
com.wire.android.GlobalObserversManagerTest ‑ given app visible and invalid session, when handling ephemeral messages, then do not call deleteEphemeralMessageEndDate()
com.wire.android.GlobalObserversManagerTest ‑ given app visible and no session, when handling ephemeral messages, then do not call deleteEphemeralMessageEndDate()
com.wire.android.GlobalObserversManagerTest ‑ given app visible and session failure, when handling ephemeral messages, then do not call deleteEphemeralMessageEndDate()
com.wire.android.GlobalObserversManagerTest ‑ given app visible and valid session, when handling ephemeral messages, then call deleteEphemeralMessageEndDate()
com.wire.android.GlobalObserversManagerTest ‑ given few valid accounts, when starting observing accounts, then create user-specific notification channels()
com.wire.android.GlobalObserversManagerTest ‑ given valid accounts, at least one with persistent socket enabled, and socket service running, then do not start service again()
com.wire.android.GlobalObserversManagerTest ‑ given validAccounts and persistentStatuses are out of sync, when setting up notifications, then ignore invalid users()
com.wire.android.SelfDeletionTimerTest ‑ givenTimeLeftIs1DayAnd12Hours_whenRecalculatingTimeAfterIntervals_thenTimeLeftIsEqualToExpected()
com.wire.android.SelfDeletionTimerTest ‑ givenTimeLeftIs1HourAnd12Minutes_whenRecalculatingTimeAfterIntervals_thenTimeLeftIsEqualToExpected()
…

@AndroidBob
Copy link
Collaborator Author

Build 4390 failed.

@MohamadJaara
Copy link
Member

@mchenani should this PR also be cherry-picked into the current RC ?

Copy link

sonarcloud bot commented May 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

This PR is stale because it has been open 30 days with no activity. Please update it or close it in case is not relevant anymore.

@github-actions github-actions bot added the stale Inactivity alert label Jun 15, 2024
@stale stale bot removed the stale Inactivity alert label Jun 24, 2024
Copy link

sonarcloud bot commented Jun 24, 2024

@yamilmedina yamilmedina added this pull request to the merge queue Jun 24, 2024
Copy link
Contributor

Built wire-android-staging-release-pr-2930.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-2930.apk is available for download

Merged via the queue into develop with commit 9e16636 Jun 24, 2024
10 checks passed
@yamilmedina yamilmedina deleted the chore/separate-lower-keypackage-limit-and-disable-cherry-pick branch June 24, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants