Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove duplicated debug id in settings screen [WPB-8626] #2926

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Apr 23, 2024

BugWPB-8626 [Android] Duplicated debug identifier in settings screen


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

On debug settings screen there is a duplicated remove identifier, and one of them is not working the copy button.

Solutions

Remove one of them, the one that doesn't have "on click" properly working.

Testing

How to Test

Open debug settings screen.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@saleniuk saleniuk requested review from a team, typfel, yamilmedina, alexandreferris, mchenani and Garzas and removed request for a team April 23, 2024 07:36
Copy link
Contributor

github-actions bot commented Apr 23, 2024

Test Results

819 tests   819 ✅  9m 29s ⏱️
110 suites    0 💤
110 files      0 ❌

Results for commit 3204a30.

♻️ This comment has been updated with latest results.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 4382 succeeded.

The build produced the following APK's:

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 4400 succeeded.

The build produced the following APK's:

@saleniuk saleniuk merged commit ac56dd3 into release/candidate Apr 24, 2024
12 checks passed
@saleniuk saleniuk deleted the fix/remove-duplicated-debug-id branch April 24, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants