-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: make learn more links clickable for automation [WPB-5888] #2923
refactor: make learn more links clickable for automation [WPB-5888] #2923
Conversation
Ups 🫰🟨This PR is too big. Please try to break it up into smaller PRs. |
Build 4376 failed. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2923 +/- ##
===========================================
- Coverage 43.99% 43.80% -0.19%
===========================================
Files 441 442 +1
Lines 14318 14334 +16
Branches 2478 2479 +1
===========================================
- Hits 6299 6279 -20
- Misses 7327 7372 +45
+ Partials 692 683 -9
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
APKs built during tests are available here. Scroll down to Artifacts! |
Build 4381 succeeded. The build produced the following APK's: |
Cherry pick from the original PR:
app/src/main/kotlin/com/wire/android/ui/home/conversations/SystemMessageItem.kt
core/ui-common/src/main/kotlin/com/wire/android/ui/common/WireDialog.kt
kalium
PR Submission Checklist for internal contributors
The PR Title
The PR Description
What's new in this PR?
Issues
Links at the end of the text like learn more are not clickable by the automation.
Solutions
Extract these links into a separate composable by using .
It's not perfect as it won't split the link text part and move part to the second line if doesn't fit but it will then move the whole link text to the next line, but it's the best compromise.
Created to make it very easy to use in the app.
Attachments (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References