Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make learn more links clickable for automation [WPB-5888] #2923

Merged

Conversation

AndroidBob
Copy link
Collaborator

@AndroidBob AndroidBob commented Apr 22, 2024

TaskWPB-5888 [Android] Separate links from dialogs - enabling automated testing

Cherry pick from the original PR:


⚠️ Conflicts during cherry-pick:
app/src/main/kotlin/com/wire/android/ui/home/conversations/SystemMessageItem.kt
core/ui-common/src/main/kotlin/com/wire/android/ui/common/WireDialog.kt
kalium


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Links at the end of the text like learn more are not clickable by the automation.

Solutions

Extract these links into a separate composable by using .
It's not perfect as it won't split the link text part and move part to the second line if doesn't fit but it will then move the whole link text to the next line, but it's the best compromise.
Created to make it very easy to use in the app.

Attachments (Optional)

image

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. .

@AndroidBob AndroidBob added the cherry-pick PR is cherry-picking changes from another banch label Apr 22, 2024
Copy link

Ups 🫰🟨

This PR is too big. Please try to break it up into smaller PRs.

Copy link
Contributor

github-actions bot commented Apr 22, 2024

Test Results

903 tests  ±0   903 ✅ ±0   8m 29s ⏱️ - 3m 34s
123 suites ±0     0 💤 ±0 
123 files   ±0     0 ❌ ±0 

Results for commit 943486d. ± Comparison against base commit fc14ebb.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator Author

Build 4376 failed.

@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 43.80%. Comparing base (8aa0aea) to head (943486d).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2923      +/-   ##
===========================================
- Coverage    43.99%   43.80%   -0.19%     
===========================================
  Files          441      442       +1     
  Lines        14318    14334      +16     
  Branches      2478     2479       +1     
===========================================
- Hits          6299     6279      -20     
- Misses        7327     7372      +45     
+ Partials       692      683       -9     
Files Coverage Δ
...e/conversations/messages/item/SystemMessageItem.kt 0.00% <ø> (ø)
...in/kotlin/com/wire/android/util/CoreFailureUtil.kt 0.00% <0.00%> (ø)

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc14ebb...943486d. Read the comment docs.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@saleniuk saleniuk requested review from a team, yamilmedina, borichellow, MohamadJaara, vitorhugods and ohassine and removed request for a team April 23, 2024 07:26
@AndroidBob
Copy link
Collaborator Author

Build 4381 succeeded.

The build produced the following APK's:

@ohassine ohassine added this pull request to the merge queue Apr 23, 2024
Merged via the queue into develop with commit 0acad2f Apr 23, 2024
12 checks passed
@ohassine ohassine deleted the refactor/learn_more_clickable_for_automation-cherry-pick branch April 23, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants