-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: sketch general issues (WPB-8810) (WPB-8811) (WPB-8812) #2919
Conversation
@@ -104,7 +105,7 @@ fun DrawingCanvasBottomSheet( | |||
onDismissRequest = onDismissEvent, | |||
properties = ModalBottomSheetProperties( | |||
isFocusable = true, | |||
securePolicy = SecureFlagPolicy.SecureOn, | |||
securePolicy = SecureFlagPolicy.Inherit, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Black screen issue fix
@@ -172,7 +172,7 @@ private suspend fun AwaitPointerEventScope.handleGestures( | |||
do { | |||
val event = awaitPointerEvent() | |||
onDraw(event.changes.first().position) | |||
val hasNewLineDraw = event.changes.first().positionChangedIgnoreConsumed() | |||
val hasNewLineDraw = event.changes.first().positionChanged() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Several undo actions to execute fix.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2919 +/- ##
===========================================
- Coverage 43.95% 43.85% -0.10%
===========================================
Files 441 441
Lines 14318 14317 -1
Branches 2478 2477 -1
===========================================
- Hits 6293 6279 -14
- Misses 7334 7354 +20
+ Partials 691 684 -7
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
APKs built during tests are available here. Scroll down to Artifacts! |
APKs built during tests are available here. Scroll down to Artifacts! |
Build 4367 succeeded. The build produced the following APK's: |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Solutions
Attachments (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.