Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create group contacts selection, hide show less button [WPB-6975] [WPB-8813] #2916

Merged
merged 3 commits into from
Apr 22, 2024

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Apr 19, 2024

BugWPB-6975 [Android] Show less button should be hidden if list can't be minimised


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

When creating group, when you choose contacts, navigate back and forth back to choose contacts screen, button "continue" shows that there are some contacts still selected but their checkboxes are unchecked.
On contacts list, when there's more than 4, "show less" button is visible but it does nothing.

Solutions

Change the way to check if contact checkbox should be selected to compare contact's ID.
Hide "show more" / "show less" button for the default contacts list which now shows all contacts.

Testing

How to Test

Try to create new group and select some contacts and navigate back and forth like described in the Issues section.

Attachments (Optional)

Before After
newgroupbefore.mp4
newgroupafter.mp4

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@saleniuk saleniuk requested review from a team, typfel, yamilmedina, alexandreferris, borichellow and MohamadJaara and removed request for a team April 19, 2024 15:29
Copy link
Contributor

github-actions bot commented Apr 19, 2024

Test Results

900 tests  ±0   900 ✅ ±0   7m 49s ⏱️ - 4m 49s
122 suites ±0     0 💤 ±0 
122 files   ±0     0 ❌ ±0 

Results for commit 6fd6536. ± Comparison against base commit 3019bb9.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 4350 succeeded.

The build produced the following APK's:

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.99%. Comparing base (3019bb9) to head (6fd6536).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2916      +/-   ##
===========================================
+ Coverage    43.95%   43.99%   +0.04%     
===========================================
  Files          441      441              
  Lines        14318    14318              
  Branches      2478     2478              
===========================================
+ Hits          6293     6299       +6     
+ Misses        7334     7327       -7     
- Partials       691      692       +1     

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3019bb9...6fd6536. Read the comment docs.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@saleniuk saleniuk added this pull request to the merge queue Apr 22, 2024
Merged via the queue into develop with commit 37a0fe5 Apr 22, 2024
14 checks passed
@saleniuk saleniuk deleted the fix/create-group-contacts-selection branch April 22, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants