fix: create group contacts selection, hide show less button [WPB-6975] [WPB-8813] #2916
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
When creating group, when you choose contacts, navigate back and forth back to choose contacts screen, button "continue" shows that there are some contacts still selected but their checkboxes are unchecked.
On contacts list, when there's more than 4, "show less" button is visible but it does nothing.
Solutions
Change the way to check if contact checkbox should be selected to compare contact's ID.
Hide "show more" / "show less" button for the default contacts list which now shows all contacts.
Testing
How to Test
Try to create new group and select some contacts and navigate back and forth like described in the
Issues
section.Attachments (Optional)
newgroupbefore.mp4
newgroupafter.mp4
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.