Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update dependencies #2911

Merged
merged 3 commits into from
Apr 19, 2024
Merged

feat: update dependencies #2911

merged 3 commits into from
Apr 19, 2024

Conversation

ohassine
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Updating some dependencies to latest version

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine requested review from a team, alexandreferris, borichellow, vitorhugods, Garzas and saleniuk and removed request for a team April 18, 2024 14:17
@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.95%. Comparing base (3d3814e) to head (71d8ae8).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2911      +/-   ##
===========================================
- Coverage    43.99%   43.95%   -0.05%     
===========================================
  Files          441      441              
  Lines        14318    14318              
  Branches      2478     2478              
===========================================
- Hits          6299     6293       -6     
- Misses        7327     7334       +7     
+ Partials       692      691       -1     

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d3814e...71d8ae8. Read the comment docs.

Copy link
Contributor

github-actions bot commented Apr 18, 2024

Test Results

900 tests  ±0   900 ✅ ±0   8m 21s ⏱️ - 6m 29s
122 suites ±0     0 💤 ±0 
122 files   ±0     0 ❌ ±0 

Results for commit 71d8ae8. ± Comparison against base commit 3d3814e.

♻️ This comment has been updated with latest results.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 4314 succeeded.

The build produced the following APK's:

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 4325 succeeded.

The build produced the following APK's:

Copy link
Contributor

@Garzas Garzas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove one comment :)

gradle/libs.versions.toml Outdated Show resolved Hide resolved
@ohassine ohassine enabled auto-merge April 19, 2024 06:51
@ohassine ohassine added this pull request to the merge queue Apr 19, 2024
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Merged via the queue into develop with commit c4c92ed Apr 19, 2024
11 of 12 checks passed
@ohassine ohassine deleted the update-dependecies branch April 19, 2024 07:33
@AndroidBob
Copy link
Collaborator

Build 4328 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants