Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bottom-sheet-dividers [WPB-3985] #2909

Merged
merged 3 commits into from
Apr 18, 2024
Merged

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Apr 18, 2024

BugWPB-3985 [Android] Divider lines are missing in conversation details / options view


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Small UI improvements to not have divider when there is no header and divider color change

@Garzas Garzas requested review from yamilmedina, saleniuk and a team April 18, 2024 09:56
@Garzas Garzas self-assigned this Apr 18, 2024
@Garzas Garzas requested review from typfel, MohamadJaara and mchenani and removed request for a team April 18, 2024 09:56
@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.99%. Comparing base (d2cc015) to head (7141291).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2909      +/-   ##
===========================================
+ Coverage    43.95%   43.99%   +0.04%     
===========================================
  Files          441      441              
  Lines        14316    14316              
  Branches      2478     2478              
===========================================
+ Hits          6293     6299       +6     
+ Misses        7332     7325       -7     
- Partials       691      692       +1     

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2cc015...7141291. Read the comment docs.

Copy link
Contributor

Test Results

900 tests  ±0   900 ✅ ±0   13m 48s ⏱️ + 5m 19s
122 suites ±0     0 💤 ±0 
122 files   ±0     0 ❌ ±0 

Results for commit 7141291. ± Comparison against base commit d2cc015.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 4297 succeeded.

The build produced the following APK's:

@yamilmedina yamilmedina added this pull request to the merge queue Apr 18, 2024
Merged via the queue into develop with commit 3d3814e Apr 18, 2024
12 checks passed
@yamilmedina yamilmedina deleted the fix/bottom-sheet-dividers branch April 18, 2024 14:40
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants