Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sketch canvas initial empty state (WPB-6960) #2908

Merged
merged 7 commits into from
Apr 18, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Apr 18, 2024

StoryWPB-6960 [Android] Drawing a sketch prototype


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

We were missing the initial arrow pointing to the toolbar, since we didn't know how to correctly position this inside the canvas dynamically.

Causes (Optional)

Only some components that we can draw in canvas, ie, drawText can have a TopLeft offset, that we can use to position in screen.

Solutions

Instead of using ImageVector, use an ImageBitmap that can be used with drawImage that has a TopLeft Offset so we can position under the text. For this reason, the image was added as a PNG instead of an SVG.

Attachments (Optional)

Screenshot 2024-04-18 at 11 46 48


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina requested review from Garzas, a team, alexandreferris, borichellow, vitorhugods and ohassine and removed request for a team April 18, 2024 09:48
@yamilmedina yamilmedina changed the title feat: empty canvas initial state (WPB-6960) feat: sketch canvas initial state (WPB-6960) Apr 18, 2024
@yamilmedina yamilmedina changed the title feat: sketch canvas initial state (WPB-6960) feat: sketch canvas initial empty state (WPB-6960) Apr 18, 2024
Copy link
Contributor

@Garzas Garzas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⬇️

@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 43.99%. Comparing base (d2cc015) to head (0472597).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2908      +/-   ##
===========================================
+ Coverage    43.95%   43.99%   +0.03%     
===========================================
  Files          441      441              
  Lines        14316    14318       +2     
  Branches      2478     2478              
===========================================
+ Hits          6293     6299       +6     
+ Misses        7332     7327       -5     
- Partials       691      692       +1     
Files Coverage Δ
...e/android/feature/sketch/DrawingCanvasComponent.kt 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2cc015...0472597. Read the comment docs.

Copy link
Contributor

github-actions bot commented Apr 18, 2024

Test Results

900 tests  ±0   900 ✅ ±0   14m 37s ⏱️ + 6m 8s
122 suites ±0     0 💤 ±0 
122 files   ±0     0 ❌ ±0 

Results for commit 0472597. ± Comparison against base commit d2cc015.

♻️ This comment has been updated with latest results.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 4300 succeeded.

The build produced the following APK's:

@yamilmedina yamilmedina added this pull request to the merge queue Apr 18, 2024
Merged via the queue into develop with commit 9975e60 Apr 18, 2024
12 checks passed
@yamilmedina yamilmedina deleted the fix/add-arrow-sketch branch April 18, 2024 14:14
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants