-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sketch canvas initial empty state (WPB-6960) #2908
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⬇️
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2908 +/- ##
===========================================
+ Coverage 43.95% 43.99% +0.03%
===========================================
Files 441 441
Lines 14316 14318 +2
Branches 2478 2478
===========================================
+ Hits 6293 6299 +6
+ Misses 7332 7327 -5
- Partials 691 692 +1
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
APKs built during tests are available here. Scroll down to Artifacts! |
APKs built during tests are available here. Scroll down to Artifacts! |
APKs built during tests are available here. Scroll down to Artifacts! |
Build 4300 succeeded. The build produced the following APK's: |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
We were missing the initial arrow pointing to the toolbar, since we didn't know how to correctly position this inside the canvas dynamically.
Causes (Optional)
Only some components that we can draw in canvas, ie,
drawText
can have a TopLeft offset, that we can use to position in screen.Solutions
Instead of using
ImageVector
, use anImageBitmap
that can be used withdrawImage
that has aTopLeft Offset
so we can position under the text. For this reason, the image was added as a PNG instead of an SVG.Attachments (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.