-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sketching discard confirmation (WPB-6960) #2903
feat: sketching discard confirmation (WPB-6960) #2903
Conversation
@@ -0,0 +1,174 @@ | |||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are moving components progressively, this file I created it to maintain the WireDialog
preview (that depend on components we still don't move to ui-commons
)
@@ -445,3 +299,6 @@ data class WireDialogButtonProperties( | |||
val type: WireDialogButtonType = WireDialogButtonType.Secondary, | |||
val loading: Boolean = false | |||
) | |||
|
|||
// todo, replace when markdown is moved to commons |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a reminder for us, so when we move Markdown components, we can replace this constant from there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 🚀 I can help with moving markdown to ui-commons :)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/sketching-color-picking #2903 +/- ##
================================================================
+ Coverage 43.60% 43.64% +0.04%
================================================================
Files 432 432
Lines 14151 14154 +3
Branches 2450 2450
================================================================
+ Hits 6170 6178 +8
+ Misses 7295 7290 -5
Partials 686 686
Continue to review full report in Codecov by Sentry.
|
APKs built during tests are available here. Scroll down to Artifacts! |
APKs built during tests are available here. Scroll down to Artifacts! |
Build 4260 failed. |
1181dd9
into
feat/sketching-color-picking
APKs built during tests are available here. Scroll down to Artifacts! |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Dialog discard confirmation.
Depends on
Needs to be merged before
Solutions
Testing
Test Coverage (Optional)
Attachments (Optional)
Screen.Recording.2024-04-17.at.10.23.37.mov
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.