Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sketching discard confirmation (WPB-6960) #2903

Merged

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Apr 17, 2024

StoryWPB-6960 [Android] Drawing a sketch prototype


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Dialog discard confirmation.

Depends on

Needs to be merged before

Solutions

  • Move Wire dialog to UI commons
  • Implement the dialog using this common component.

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

Attachments (Optional)

Screen.Recording.2024-04-17.at.10.23.37.mov

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina requested review from Garzas, a team, MohamadJaara, vitorhugods, mchenani and saleniuk and removed request for a team April 17, 2024 08:27
@@ -0,0 +1,174 @@
/*
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are moving components progressively, this file I created it to maintain the WireDialog preview (that depend on components we still don't move to ui-commons)

@@ -445,3 +299,6 @@ data class WireDialogButtonProperties(
val type: WireDialogButtonType = WireDialogButtonType.Secondary,
val loading: Boolean = false
)

// todo, replace when markdown is moved to commons
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a reminder for us, so when we move Markdown components, we can replace this constant from there.

Copy link
Contributor

@Garzas Garzas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🚀 I can help with moving markdown to ui-commons :)

@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.64%. Comparing base (9e6ee78) to head (592a9a9).

Additional details and impacted files
@@                       Coverage Diff                        @@
##           feat/sketching-color-picking    #2903      +/-   ##
================================================================
+ Coverage                         43.60%   43.64%   +0.04%     
================================================================
  Files                               432      432              
  Lines                             14151    14154       +3     
  Branches                           2450     2450              
================================================================
+ Hits                               6170     6178       +8     
+ Misses                             7295     7290       -5     
  Partials                            686      686              
Files Coverage Δ
...e/android/feature/sketch/DrawingCanvasViewModel.kt 49.12% <100.00%> (+10.94%) ⬆️
...roid/feature/sketch/model/DrawingPathProperties.kt 9.09% <ø> (ø)
.../wire/android/feature/sketch/model/DrawingState.kt 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e6ee78...592a9a9. Read the comment docs.

Copy link
Contributor

github-actions bot commented Apr 17, 2024

Test Results

888 tests  +3   888 ✅ +3   16m 16s ⏱️ + 7m 16s
122 suites ±0     0 💤 ±0 
122 files   ±0     0 ❌ ±0 

Results for commit 592a9a9. ± Comparison against base commit 9e6ee78.

♻️ This comment has been updated with latest results.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@pull-request-size pull-request-size bot added size/L and removed size/M labels Apr 17, 2024
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 4260 failed.

@yamilmedina yamilmedina merged commit 1181dd9 into feat/sketching-color-picking Apr 17, 2024
8 of 9 checks passed
@yamilmedina yamilmedina deleted the feat/sketching-discard-confirmation branch April 17, 2024 10:27
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants