Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display avs and CC version on all builds #2900

Merged

Conversation

AndroidBob
Copy link
Collaborator

Cherry pick from the original PR:


⚠️ Conflicts during cherry-pick:
app/src/main/kotlin/com/wire/android/ui/debug/DebugDataOptions.kt


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

  1. CC is displaing the wrong version.
  2. the version is only displaied on internal builds.
  3. the code for debug screen is all in one place

Solutions

  1. include the correct one
  2. display is for all flavors.
  3. clean up

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. .

@AndroidBob AndroidBob added the cherry-pick PR is cherry-picking changes from another banch label Apr 16, 2024
Copy link
Contributor

github-actions bot commented Apr 16, 2024

Test Results

890 tests  ±0   890 ✅ ±0   15m 12s ⏱️ - 2m 53s
122 suites ±0     0 💤 ±0 
122 files   ±0     0 ❌ ±0 

Results for commit 873f6ce. ± Comparison against base commit 7e10577.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator Author

Build 4240 failed.

@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 92 lines in your changes are missing coverage. Please review.

Project coverage is 43.73%. Comparing base (7e10577) to head (873f6ce).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2900   +/-   ##
========================================
  Coverage    43.72%   43.73%           
========================================
  Files          435      437    +2     
  Lines        14258    14257    -1     
  Branches      2476     2476           
========================================
  Hits          6235     6235           
+ Misses        7330     7329    -1     
  Partials       693      693           
Files Coverage Δ
...tlin/com/wire/android/ui/debug/DebugDataOptions.kt 0.00% <0.00%> (ø)
...com/wire/android/ui/debug/DebugDataOptionsState.kt 0.00% <0.00%> (ø)
...wire/android/ui/debug/DebugDataOptionsViewModel.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e10577...873f6ce. Read the comment docs.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator Author

Build 4254 succeeded.

The build produced the following APK's:

Copy link
Contributor

@Garzas Garzas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, 2 small questions

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator Author

Build 4272 succeeded.

The build produced the following APK's:

@MohamadJaara MohamadJaara added this pull request to the merge queue Apr 17, 2024
Merged via the queue into develop with commit 9c95a14 Apr 17, 2024
12 checks passed
@MohamadJaara MohamadJaara deleted the fix/display-avs-and-cc-version-on-prod-app-cherry-pick branch April 17, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants