Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: misleading e2ei certificate error dialog (WPB-7129) #2885

Conversation

AndroidBob
Copy link
Collaborator

@AndroidBob AndroidBob commented Apr 11, 2024

BugWPB-7129 [Android] Misleading dialogue if certificate generation fails after login with e2ei enabled

Cherry pick from the original PR:


⚠️ Conflicts during cherry-pick:


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

The old copy for error when getting certificate was wrong.

Solutions

Adjust dialog with new copy

Dependencies (Optional)

Needs releases with:

Testing

How to Test

  • Have env. with E2EI enabled and wrong ACME URL
  • login and try to generate certificate
  • error dialog will popup with correct copy

Attachments (Optional)

Before After
old new

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. .

@AndroidBob AndroidBob added the cherry-pick PR is cherry-picking changes from another banch label Apr 11, 2024
@alexandreferris alexandreferris requested review from a team, typfel, alexandreferris, borichellow, MohamadJaara and ohassine and removed request for a team April 11, 2024 14:02
Copy link
Contributor

Test Results

888 tests   888 ✅  17m 53s ⏱️
122 suites    0 💤
122 files      0 ❌

Results for commit 829d4fc.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator Author

Build 4128 succeeded.

The build produced the following APK's:

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.79%. Comparing base (2d77b2f) to head (829d4fc).
Report is 16 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2885      +/-   ##
===========================================
- Coverage    43.80%   43.79%   -0.01%     
===========================================
  Files          424      432       +8     
  Lines        14066    14167     +101     
  Branches      2501     2455      -46     
===========================================
+ Hits          6161     6205      +44     
- Misses        7187     7269      +82     
+ Partials       718      693      -25     

see 104 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2b700e...829d4fc. Read the comment docs.

@alexandreferris alexandreferris added this pull request to the merge queue Apr 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 12, 2024
@alexandreferris alexandreferris added this pull request to the merge queue Apr 12, 2024
Merged via the queue into develop with commit 1b04e30 Apr 12, 2024
13 checks passed
@alexandreferris alexandreferris deleted the fix/misleading_e2ei_certificate_error_dialog-cherry-pick branch April 12, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants