-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: misleading e2ei certificate error dialog (WPB-7129) #2885
fix: misleading e2ei certificate error dialog (WPB-7129) #2885
Conversation
Signed-off-by: alexandreferris <[email protected]>
Test Results888 tests 888 ✅ 17m 53s ⏱️ Results for commit 829d4fc. |
APKs built during tests are available here. Scroll down to Artifacts! |
Build 4128 succeeded. The build produced the following APK's: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2885 +/- ##
===========================================
- Coverage 43.80% 43.79% -0.01%
===========================================
Files 424 432 +8
Lines 14066 14167 +101
Branches 2501 2455 -46
===========================================
+ Hits 6161 6205 +44
- Misses 7187 7269 +82
+ Partials 718 693 -25 see 104 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Cherry pick from the original PR:
PR Submission Checklist for internal contributors
The PR Title
The PR Description
What's new in this PR?
Issues
The old copy for error when getting certificate was wrong.
Solutions
Adjust dialog with new copy
Dependencies (Optional)
Needs releases with:
Testing
How to Test
Attachments (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References