Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typing): back handler and jumping screen typing indicator #2325

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Oct 13, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

In the playtest session we discover

  • A padding issue, that made the messages jump.
  • System back handler didn't send a stop event.

Solutions

Add fixed element for ui adjustment, and make inside content displayable according to list empty or not.
Implements BackHandler in conversation screen to send the stop event.

Testing

How to Test

Receive some typing events should not make jump messages and going back to conversation list should send a stop event to other clients.

Attachments (Optional)

Screen.Recording.2023-10-13.at.16.17.00.mov

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

Test Results

644 tests  ±0   644 ✔️ ±0   5m 53s ⏱️ - 2m 10s
  93 suites ±0       0 💤 ±0 
  93 files   ±0       0 ±0 

Results for commit 33e1ddd. ± Comparison against base commit d3d6bf7.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

focusManager: FocusManager,
navigator: Navigator
) {
messageComposerViewModel.sendTypingEvent(TypingIndicatorMode.STOPPED)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought: Not for this PR itself, but it would be best if the the ViewModel isn't commanded by the UI. i.e. instead of viewModel.sendTypingEvent it could be something like viewModel.onNavigateBack and then the ViewModel decides what should be done.

@yamilmedina yamilmedina added this pull request to the merge queue Oct 13, 2023
@AndroidBob
Copy link
Collaborator

Build 1296 succeeded.

The build produced the following APK's:

Merged via the queue into develop with commit 88adc9e Oct 13, 2023
19 checks passed
@yamilmedina yamilmedina deleted the fix/typing-sentstopped-and-padding branch October 13, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants