Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modify download placeholders to clarify saved and downloaded cases [WPB-4732] #2322

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

gongracr
Copy link
Contributor

@gongracr gongracr commented Oct 12, 2023

BugWPB-4732 Applause -[Android] Chat - Poor translated "download" button


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

There was still some confussion among users with Assets being downloaded externally and saved internally when sending and receiving these over conversations. Also icons were not helping as they were being displayed in multiple ways, adding to the problematic, so they have been removed following the design specs in Figma.

Solutions

Substituted "Downloaded copy" on the asset placeholder for "Tap to view" in order to help user understand that the asset is ready to use.

Attachments (Optional)

Captura de pantalla 2023-10-12 a las 15 57 23
References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@gongracr gongracr requested review from a team, typfel, yamilmedina, alexandreferris, Garzas and saleniuk and removed request for a team October 12, 2023 14:52
@gongracr gongracr removed the request for review from typfel October 12, 2023 14:53
@AndroidBob
Copy link
Collaborator

Build 1270 succeeded.

The build produced the following APK's:

@github-actions
Copy link
Contributor

Test Results

644 tests  ±0   644 ✔️ ±0   11m 9s ⏱️ + 6m 24s
  93 suites ±0       0 💤 ±0 
  93 files   ±0       0 ±0 

Results for commit 025cfd4. ± Comparison against base commit e096a5b.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@gongracr gongracr added this pull request to the merge queue Oct 12, 2023
Merged via the queue into develop with commit 052384e Oct 12, 2023
15 checks passed
@gongracr gongracr deleted the fix/download_copy branch October 12, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants