-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: sanitize urls before displaying warning dialog [WPB-4782] #2320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gongracr
requested review from
a team,
typfel,
yamilmedina,
alexandreferris,
borichellow and
ohassine
and removed request for
a team
October 12, 2023 12:15
Build 1260 failed. |
alexandreferris
approved these changes
Oct 12, 2023
yamilmedina
approved these changes
Oct 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice extra layer of security here 👀
Build 1267 failed. |
Build 1271 failed. |
APKs built during tests are available here. Scroll down to Artifacts! |
Build 1276 succeeded. The build produced the following APK's: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Some users might try to send links on chats with hidden punycodes camouflaged as normal links. Therefore, we need to sanitize all urls before displaying the warning dialog to users to make sure they are aware where they will be navigating to.
Solutions
Use the
IDN.toASCII()
method to transform to ASCII any malicious characters.Attachments (Optional)
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.