Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update archiving dialog copy #2312

Merged
merged 1 commit into from
Oct 10, 2023
Merged

fix: update archiving dialog copy #2312

merged 1 commit into from
Oct 10, 2023

Conversation

gongracr
Copy link
Contributor

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Update archiving dialog copy to be more precise about the fact that archived conversations will not generate any type of notifications.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

Test Results

629 tests  ±0   629 ✔️ ±0   6m 29s ⏱️ - 2m 40s
  92 suites ±0       0 💤 ±0 
  92 files   ±0       0 ❌ ±0 

Results for commit f37d00e. ± Comparison against base commit d2fcaa7.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@gongracr gongracr added this pull request to the merge queue Oct 10, 2023
@AndroidBob
Copy link
Collaborator

Build 1214 succeeded.

The build produced the following APK's:

Merged via the queue into develop with commit b766887 Oct 10, 2023
15 checks passed
@gongracr gongracr deleted the fix/archiving_dialog_copy branch October 10, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ohassine ohassine ohassine approved these changes

@alexandreferris alexandreferris alexandreferris approved these changes

@yamilmedina yamilmedina Awaiting requested review from yamilmedina

Assignees

@gongracr gongracr

Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gongracr @AndroidBob @alexandreferris @ohassine