Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade CC to 1.0.0.rc14 #2307

Closed
wants to merge 4 commits into from

Conversation

typfel
Copy link
Member

@typfel typfel commented Oct 9, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Upgrade to CC 1.0.0.rc14, see linked PR for details.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit d49db47.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1191 succeeded.

The build produced the following APK's:

@typfel typfel force-pushed the chore/upgrade-cc-1.0.0.rc14 branch from 7491a6c to d49db47 Compare October 10, 2023 08:16
@AndroidBob
Copy link
Collaborator

Build 1208 failed.

@AndroidBob
Copy link
Collaborator

Build 1421 failed.

@github-actions
Copy link
Contributor

@typfel looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (release/candidate) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

release/candidate This PR
8e05b70d76349c0494ec96064c1daefda083a132 2d2f00f47f7eb2c7b50b74859ea8ad91ac7a520e

Is this intentional?

@yamilmedina
Copy link
Contributor

@typfel looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (release/candidate) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

release/candidate This PR
8e05b70d76349c0494ec96064c1daefda083a132 2d2f00f47f7eb2c7b50b74859ea8ad91ac7a520e
Is this intentional?

False positive, 2d2f00f47f7eb2c7b50b74859ea8ad91ac7a520e it's the latest on Kalium RC

@typfel
Copy link
Member Author

typfel commented Oct 19, 2023

@typfel looks like you are rolling back kalium to a previous commitish.
This means that the PR's target branch (release/candidate) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.
release/candidate This PR
8e05b70d76349c0494ec96064c1daefda083a132 2d2f00f47f7eb2c7b50b74859ea8ad91ac7a520e
Is this intentional?

False positive, 2d2f00f47f7eb2c7b50b74859ea8ad91ac7a520e it's the latest on Kalium RC

But this PR is outdated anyway we went with the 1.0.0-pre6 schema fix release.

@typfel typfel closed this Oct 19, 2023
@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1422 succeeded.

The build produced the following APK's:

@yamilmedina yamilmedina deleted the chore/upgrade-cc-1.0.0.rc14 branch March 29, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants