fix(links): embedded links with escaped chars [e.g. plus] (WPB-4402) #2268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchenani
requested review from
gongracr,
alexandreferris,
vitorhugods and
Garzas
Garzas
approved these changes
Sep 25, 2023
|
APKs built during tests are available here. Scroll down to Artifacts! |
alexandreferris
approved these changes
Sep 25, 2023
|
Build 939 succeeded. The build produced the following APK's: |
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
APKs built during tests are available here. Scroll down to Artifacts! |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
|
Build 952 succeeded. The build produced the following APK's: |
mchenani
added a commit
that referenced
this pull request
Oct 18, 2023
…2268) Co-authored-by: Oussama Hassine <[email protected]> (cherry picked from commit 9311af3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
When the embedded link in a message, was encoded with escape chars such as +, we were decoding it unnecessary and that was causing an error in detecting the url as invalid one, in the result we were adding an extra schema [https] to the valid link.
Issues
Adding an extra schema [https] to the valid link with escape chars.
Causes (Optional)
Unneeded decoding.
Solutions
Removed the unneeded decoding, and adding more tests.
Testing
Test Coverage (Optional)
How to Test
Have an embedded link like: https://google.com/this+is+a+test, the link the app tried to open should be the same and with only one https.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.