Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Self video disappears when scrolling through video grid (WPB-4651) #2246

Merged
merged 5 commits into from
Sep 20, 2023

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Sep 19, 2023

BugWPB-4651 [Android] Self video disappears when scrolling through video grid


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Sister PR of #2245


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine requested review from a team, typfel, yamilmedina, vitorhugods, trOnk12 and saleniuk and removed request for a team September 19, 2023 14:37
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #2246 (5fc6fe0) into develop (f194001) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #2246      +/-   ##
=============================================
- Coverage      40.45%   40.45%   -0.01%     
  Complexity      1002     1002              
=============================================
  Files            316      316              
  Lines          11555    11557       +2     
  Branches        1535     1535              
=============================================
  Hits            4675     4675              
- Misses          6441     6443       +2     
  Partials         439      439              
Files Changed Coverage Δ
.../calling/ongoing/fullscreen/SelectedParticipant.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f194001...5fc6fe0. Read the comment docs.

@github-actions
Copy link
Contributor

Test Results

607 tests  ±0   606 ✔️ ±0   5m 20s ⏱️ - 2m 47s
  86 suites ±0       1 💤 ±0 
  86 files   ±0       0 ±0 

Results for commit 5fc6fe0. ± Comparison against base commit f194001.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 848 succeeded.

The build produced the following APK's:

@ohassine ohassine added this pull request to the merge queue Sep 20, 2023
Merged via the queue into develop with commit 3212c31 Sep 20, 2023
20 checks passed
@ohassine ohassine deleted the unnecessary_recomposition branch September 20, 2023 08:33
ohassine added a commit that referenced this pull request Sep 22, 2023
@ohassine ohassine mentioned this pull request Sep 22, 2023
6 tasks
github-merge-queue bot pushed a commit that referenced this pull request Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants