Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scrolling in calling grid is not smooth (WPB-4531) #2228

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Sep 12, 2023

BugWPB-4531 [Android] Scrolling is sometimes stuck when there are 9 participants in a call


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

when we have tiles displayed horizontally , scrolling pages is not smooth

Causes (Optional)

The scroll for the lazy column was enabled which will affect and interfere with pager scrolling behaviour.

Solutions

Disable scrolling for lazy column

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

  • Have a call with 9 particpants
  • Try to scroll to second page
  • Scrolling should be smooth

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

Test Results

600 tests  ±0   599 ✔️ ±0   4m 36s ⏱️ - 1m 44s
  85 suites ±0       1 💤 ±0 
  85 files   ±0       0 ±0 

Results for commit c235c3d. ± Comparison against base commit 5c4b106.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 735 succeeded.

The build produced the following APK's:

@ohassine ohassine added this pull request to the merge queue Sep 13, 2023
Merged via the queue into develop with commit 3cf713f Sep 13, 2023
20 checks passed
@ohassine ohassine deleted the scrolling_not_smooth branch September 13, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants