Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(calling): scrolling the grid is not possible when every one have camera enabled (WPB-4530) #2220

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Sep 12, 2023

BugWPB-4530 [Android] Scrolling not working as expected in large calls


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

scrolling the grid is not possible when every one have camera enabled

Causes (Optional)

We are using detectTransformGestures() on the tile which will prevent the scrolling behaviour

Solutions

Use detectTransformGestures only on full screen and when video is enabled

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

  • Have a large conference call more than 8 participants
  • Try to swipe up to next page by tapping on a tile with video enabled

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine changed the title fix(calling): scrolling the grid is not possible when every one have camera enabled fix(calling): scrolling the grid is not possible when every one have camera enabled (WPB-4530) Sep 12, 2023
Copy link
Contributor

@alexandreferris alexandreferris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

@github-actions
Copy link
Contributor

Test Results

600 tests  ±0   599 ✔️ ±0   6m 45s ⏱️ +41s
  85 suites ±0       1 💤 ±0 
  85 files   ±0       0 ±0 

Results for commit b86d9d2. ± Comparison against base commit 07cab37.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 704 succeeded.

The build produced the following APK's:

@ohassine ohassine added this pull request to the merge queue Sep 12, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 12, 2023
@ohassine ohassine added this pull request to the merge queue Sep 12, 2023
Merged via the queue into develop with commit 5c4b106 Sep 12, 2023
22 checks passed
@ohassine ohassine deleted the fix_grid_scrolling branch September 12, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants