Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: message flickering [WPB-3983] #2217

Merged
merged 1 commit into from
Sep 12, 2023
Merged

fix: message flickering [WPB-3983] #2217

merged 1 commit into from
Sep 12, 2023

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Sep 12, 2023 •
edited
Loading

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Fixed issue with message flickering on recomposition when showAuthor should not be calculated again

@Garzas Garzas requested review from vitorhugods and a team September 12, 2023 10:35
@Garzas Garzas self-assigned this Sep 12, 2023
@Garzas Garzas requested review from typfel, gongracr, ohassine and saleniuk and removed request for a team September 12, 2023 10:35
@Garzas Garzas changed the title fix: message flickering fix: message flickering [WPB-3983] Sep 12, 2023
@Garzas Garzas enabled auto-merge (squash) September 12, 2023 10:44
@Garzas Garzas merged commit 872b1ae into release/candidate Sep 12, 2023
10 checks passed
@Garzas Garzas deleted the fix/message-flickering branch September 12, 2023 10:48
github-actions bot pushed a commit that referenced this pull request Sep 12, 2023
@Garzas @github-actions
fix: message flickering [WPB-3983] (#2217)
e93dfa0
@github-actions github-actions bot mentioned this pull request Sep 12, 2023
Merged
4 tasks
@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 700 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitorhugods vitorhugods vitorhugods approved these changes

@alexandreferris alexandreferris alexandreferris approved these changes

@typfel typfel Awaiting requested review from typfel typfel was automatically assigned from wireapp/android

@gongracr gongracr Awaiting requested review from gongracr gongracr was automatically assigned from wireapp/android

@ohassine ohassine Awaiting requested review from ohassine ohassine was automatically assigned from wireapp/android

@saleniuk saleniuk Awaiting requested review from saleniuk saleniuk was automatically assigned from wireapp/android

Assignees

@Garzas Garzas

Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Garzas @AndroidBob @alexandreferris @vitorhugods